Mailing List Archive

Hi Maurits,

Maurits van Rees wrote:
> Just a friendly reminder that there are two pending pull requests by me
> for GenericSetup.
>
> Pep8, mostly in tests:
> https://github.com/zopefoundation/Products.GenericSetup/pull/21
>
> Add unsetLastVersionForProfile and purgeProfileVersions. Call
> purgeProfileVersions for base profiles:
> https://github.com/zopefoundation/Products.GenericSetup/pull/18
>
> I know, everyone is busy, no problem.

what exactly are you waiting for?


Cheers,

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Op 26/10/15 om 09:27 schreef yuppie:
> Hi Maurits,
>
> Maurits van Rees wrote:
>> Just a friendly reminder that there are two pending pull requests by me
>> for GenericSetup.
>>
>> Pep8, mostly in tests:
>> https://github.com/zopefoundation/Products.GenericSetup/pull/21
>>
>> Add unsetLastVersionForProfile and purgeProfileVersions. Call
>> purgeProfileVersions for base profiles:
>> https://github.com/zopefoundation/Products.GenericSetup/pull/18
>>
>> I know, everyone is busy, no problem.
>
> what exactly are you waiting for?

Well, you seem okay with it now, but I am not sure about Tres.
They are my pull requests, so it's nicer if I don't merge them myself.

But yeah, if no one merges it or voices last minute concerns, I will
merge them tomorrow.


--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

_______________________________________________
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/26/2015 07:04 AM, Maurits van Rees wrote:
> Op 26/10/15 om 09:27 schreef yuppie:
>> Hi Maurits,
>>
>> Maurits van Rees wrote:
>>> Just a friendly reminder that there are two pending pull requests
>>> by me for GenericSetup.
>>>
>>> Pep8, mostly in tests:
>>> https://github.com/zopefoundation/Products.GenericSetup/pull/21
>>>
>>> Add unsetLastVersionForProfile and purgeProfileVersions. Call
>>> purgeProfileVersions for base profiles:
>>> https://github.com/zopefoundation/Products.GenericSetup/pull/18
>>>
>>> I know, everyone is busy, no problem.
>>
>> what exactly are you waiting for?
>
> Well, you seem okay with it now, but I am not sure about Tres. They
> are my pull requests, so it's nicer if I don't merge them myself.
>
> But yeah, if no one merges it or voices last minute concerns, I will
> merge them tomorrow.

I merged the PEP8 one. Ironically, it causes conflicts with the other
one (#18).


Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver@palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWLirFAAoJEPKpaDSJE9HYO24P/2DwpoLjDarUKKBYbn6b1k+5
czVqAgKdYa9Qa5A7Y2nMGpaO4jXAzXoqQLH76FQ7Tcq0SfO/9TND0qFdskFDqEY/
K9YzXzj7xSdf/IRymT1Bvqoxf8lgG/3GDWWkkhzdxknn0KW02TIU1GLf5D7RjPBN
NFNowgEY9enOcvFQjdEhKgZ2lpNiLNYEiltP695R3CM3r9eGgOwF+WIOaMCN9Y5d
VRY4D08cpsWA6xuzCseSp7guDOcLk+Y214J6w8L6ry5kr3mTAN46WULu41kq4seN
UARLbG9T/H8zkq9W3cYlbDnsob0tx6Ww28hAWF2upWs/88sYDfsWa5fugC30y9cy
o+XR6GJwzjh2gBwTgGfPK/HluSeZXouXbHgq0pko9c4puyfB/HMG8yGNeHY8jGZw
PNPwZ/h+acV+KoWWEMPzQIvDcgEpNwYqizZ49BeMS/svsVrdi2e5QeLU9MZGxhIa
AQXpSOS2ZALg/6DIfBJnOnQZhDP3PDRx88aBISTlseDTBpvOyStNsF9/peFD5K5n
pHQSvGQu5Yb+q3OIrti3++raax2lBK8xg86BVoVE1xUf9EYGpKRxFHjnc5X1Cj9E
yX49d0TPykLJD49ovO5IxwG4KiKV++clOwkJrwxycvj/uQclW1z1NlvRqxWwSp5p
AOslei4QzDCgdUG8bufC
=7Iy8
-----END PGP SIGNATURE-----

_______________________________________________
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Op 26/10/15 om 14:29 schreef Tres Seaver:
> I merged the PEP8 one. Ironically, it causes conflicts with the other
> one (#18).

Thanks.

Conflict was to be expected. I have rebased the other pull request.

--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

_______________________________________________
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Op 26/10/15 om 14:43 schreef Maurits van Rees:
> Conflict was to be expected. I have rebased the other pull request.

I have merged that one too.

Ready for a release I would say.


--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

_______________________________________________
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests