Mailing List Archive: [PATCH 1/7] x86/p2m: Add braces for better code clarity

[PATCH 1/7] x86/p2m: Add braces for better code clarity

Apr 24, 2024, 1:41 PM

Post #1 of 4 (11 views)

From: Petr Beneš <w1benny@gmail.com>

No functional change.

Signed-off-by: Petr Beneš <w1benny@gmail.com>
---
xen/arch/x86/mm/p2m.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index ce742c12e0..eb7996170d 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -106,6 +106,7 @@ void p2m_change_entry_type_global(struct domain *d,
unsigned int i;

for ( i = 0; i < MAX_ALTP2M; i++ )
+ {
if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
{
struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
@@ -114,6 +115,7 @@ void p2m_change_entry_type_global(struct domain *d,
change_entry_type_global(altp2m, ot, nt);
p2m_unlock(altp2m);
}
+ }
}

p2m_unlock(hostp2m);
@@ -139,6 +141,7 @@ void p2m_memory_type_changed(struct domain *d)
unsigned int i;

for ( i = 0; i < MAX_ALTP2M; i++ )
+ {
if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
{
struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
@@ -147,6 +150,7 @@ void p2m_memory_type_changed(struct domain *d)
_memory_type_changed(altp2m);
p2m_unlock(altp2m);
}
+ }
}

p2m_unlock(hostp2m);
--
2.34.1

Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity [ In reply to ]

jbeulich at suse

Apr 24, 2024, 11:21 PM

Post #2 of 4 (11 views)

Permalink

On 24.04.2024 22:41, Petr Beneš wrote:
> From: Petr Beneš <w1benny@gmail.com>
>
> No functional change.
>
> Signed-off-by: Petr Beneš <w1benny@gmail.com>

Hmm. I don't really mind the extra braces, but I also don't really see a need.
IOW this is not an objection, but it'll want to be someone else (if anyone) to
ack this.

Jan

> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -106,6 +106,7 @@ void p2m_change_entry_type_global(struct domain *d,
> unsigned int i;
>
> for ( i = 0; i < MAX_ALTP2M; i++ )
> + {
> if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> {
> struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
> @@ -114,6 +115,7 @@ void p2m_change_entry_type_global(struct domain *d,
> change_entry_type_global(altp2m, ot, nt);
> p2m_unlock(altp2m);
> }
> + }
> }
>
> p2m_unlock(hostp2m);
> @@ -139,6 +141,7 @@ void p2m_memory_type_changed(struct domain *d)
> unsigned int i;
>
> for ( i = 0; i < MAX_ALTP2M; i++ )
> + {
> if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> {
> struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
> @@ -147,6 +150,7 @@ void p2m_memory_type_changed(struct domain *d)
> _memory_type_changed(altp2m);
> p2m_unlock(altp2m);
> }
> + }
> }
>
> p2m_unlock(hostp2m);

Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity [ In reply to ]

w1benny at gmail

Apr 25, 2024, 1:41 AM

Post #3 of 4 (11 views)

Permalink

On Thu, Apr 25, 2024 at 8:21?AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 24.04.2024 22:41, Petr Beneš wrote:
> > From: Petr Beneš <w1benny@gmail.com>
> >
> > No functional change.
> >
> > Signed-off-by: Petr Beneš <w1benny@gmail.com>
>
> Hmm. I don't really mind the extra braces, but I also don't really see a need.
> IOW this is not an objection, but it'll want to be someone else (if anyone) to
> ack this.
>
> Jan
>
> > --- a/xen/arch/x86/mm/p2m.c
> > +++ b/xen/arch/x86/mm/p2m.c
> > @@ -106,6 +106,7 @@ void p2m_change_entry_type_global(struct domain *d,
> > unsigned int i;
> >
> > for ( i = 0; i < MAX_ALTP2M; i++ )
> > + {
> > if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> > {
> > struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
> > @@ -114,6 +115,7 @@ void p2m_change_entry_type_global(struct domain *d,
> > change_entry_type_global(altp2m, ot, nt);
> > p2m_unlock(altp2m);
> > }
> > + }
> > }
> >
> > p2m_unlock(hostp2m);
> > @@ -139,6 +141,7 @@ void p2m_memory_type_changed(struct domain *d)
> > unsigned int i;
> >
> > for ( i = 0; i < MAX_ALTP2M; i++ )
> > + {
> > if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> > {
> > struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
> > @@ -147,6 +150,7 @@ void p2m_memory_type_changed(struct domain *d)
> > _memory_type_changed(altp2m);
> > p2m_unlock(altp2m);
> > }
> > + }
> > }
> >
> > p2m_unlock(hostp2m);
>

I should have specified that it builds on commit
5205bda5f11cc03ca62ad2bb6c34bf738bbb3247, which did some coding style
cleanup and added braces to several places too, but missed these two.

Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity [ In reply to ]

sstabellini at kernel

Apr 25, 2024, 4:38 PM

Post #4 of 4 (11 views)

Permalink

On Wed, 24 Apr 2024, Petr Beneš wrote:
> From: Petr Beneš <w1benny@gmail.com>
>
> No functional change.
>
> Signed-off-by: Petr Beneš <w1benny@gmail.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>