Mailing List Archive: Re: [PATCH v3 2/3] x86/svm: Drop the suffix

On 13.03.2024 17:41, Vaishali Thakkar wrote:
> The suffix _guest is redundant for asid bit. Drop it
> to avoid adding extra code volume.
>
> While we're here, replace 0/1 with false/true and use
> VMCB accessors instead of open coding.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@vates.tech>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with ...

> --- a/xen/arch/x86/hvm/svm/asid.c
> +++ b/xen/arch/x86/hvm/svm/asid.c
> @@ -37,14 +37,14 @@ void svm_asid_handle_vmrun(void)
> /* ASID 0 indicates that ASIDs are disabled. */
> if ( p_asid->asid == 0 )
> {
> - vmcb_set_guest_asid(vmcb, 1);
> + vmcb_set_asid(vmcb,true);

... the blank put back that was lost here (can be done while committing).

Jan

On 3/14/24 17:04, Jan Beulich wrote:
> On 13.03.2024 17:41, Vaishali Thakkar wrote:
>> The suffix _guest is redundant for asid bit. Drop it
>> to avoid adding extra code volume.
>>
>> While we're here, replace 0/1 with false/true and use
>> VMCB accessors instead of open coding.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@vates.tech>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with ...
>
>> --- a/xen/arch/x86/hvm/svm/asid.c
>> +++ b/xen/arch/x86/hvm/svm/asid.c
>> @@ -37,14 +37,14 @@ void svm_asid_handle_vmrun(void)
>> /* ASID 0 indicates that ASIDs are disabled. */
>> if ( p_asid->asid == 0 )
>> {
>> - vmcb_set_guest_asid(vmcb, 1);
>> + vmcb_set_asid(vmcb,true);
>
> ... the blank put back that was lost here (can be done while committing).

Thanks

> Jan