Mailing List Archive

On 20/12/2012 18:55, "Ross Philipson" <Ross.Philipson@citrix.com> wrote:

> Add public HVM definitions header for firmware passthrough support (including
> comment describing the feature's use). In addition this header is used to
> collect the various xenstore string values that are used in HVMLOADER.

Please give this header file a more descriptive name, and place it under
xen/include/public/hvm/ (from whence it will be linked into the
tools/include/ namespace at build time, and accessible from there by tools
and hvmloader sources).

You will need to spin a v5 of this patchset.

I'm happy with you leaving xl integration until after this patchset is in
the tree, personally. Unless any of the toolstack team wants to veto that.

-- Keir

> Signed-off-by: Ross Philipson <ross.philipson@citrix.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

> -----Original Message-----
> From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser
> Sent: Wednesday, January 09, 2013 3:42 AM
> To: Ross Philipson; xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] [PATCH v4 01/04] HVM firmware passthrough HVM
> defs header
>
> On 20/12/2012 18:55, "Ross Philipson" <Ross.Philipson@citrix.com> wrote:
>
> > Add public HVM definitions header for firmware passthrough support
> (including
> > comment describing the feature's use). In addition this header is used
> to
> > collect the various xenstore string values that are used in HVMLOADER.
>
> Please give this header file a more descriptive name, and place it under
> xen/include/public/hvm/ (from whence it will be linked into the
> tools/include/ namespace at build time, and accessible from there by
> tools
> and hvmloader sources).
>
> You will need to spin a v5 of this patchset.

Wilco, thanks

>
> I'm happy with you leaving xl integration until after this patchset is
> in
> the tree, personally. Unless any of the toolstack team wants to veto
> that.
>
> -- Keir
>
> > Signed-off-by: Ross Philipson <ross.philipson@citrix.com>
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel