Mailing List Archive

struct xen_add_to_physmap UNION
Hi,

What's the latest on the union of size/foreign_domid. I don't see it
checked in xen unstable. Final decision is to unionize it, right? It
doesn't matter for PVH either way.

+++ b/xen/include/public/memory.h Thu Oct 11 16:24:47 2012 -0700
@@ -208,14 +208,19 @@ struct xen_add_to_physmap {
/* Which domain to change the mapping for. */
domid_t domid;

- /* Number of pages to go through for gmfn_range */
- uint16_t size;
+ union {
+ /* Number of pages to go through for gmfn_range */
+ uint16_t size;
+ /* IFF XENMAPSPACE_gmfn_foreign */
+ domid_t foreign_domid;
+ } u;


thanks,
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: struct xen_add_to_physmap UNION [ In reply to ]
On Fri, 2012-10-12 at 00:26 +0100, Mukesh Rathor wrote:
> Hi,
>
> What's the latest on the union of size/foreign_domid. I don't see it
> checked in xen unstable. Final decision is to unionize it, right? It
> doesn't matter for PVH either way.

I think the final decision is to go with XENMEM_add_to_physmap_range,
see <1349433507-21148-1-git-send-email-ian.campbell@citrix.com>.

Ian.

>
> +++ b/xen/include/public/memory.h Thu Oct 11 16:24:47 2012 -0700
> @@ -208,14 +208,19 @@ struct xen_add_to_physmap {
> /* Which domain to change the mapping for. */
> domid_t domid;
>
> - /* Number of pages to go through for gmfn_range */
> - uint16_t size;
> + union {
> + /* Number of pages to go through for gmfn_range */
> + uint16_t size;
> + /* IFF XENMAPSPACE_gmfn_foreign */
> + domid_t foreign_domid;
> + } u;
>
>
> thanks,
> Mukesh



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel