Mailing List Archive: [PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang

[PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang

Dec 13, 2011, 8:12 AM

Post #1 of 4 (142 views)

Currently PVHVM Linux guests after ddacf5ef684a "xen/pv-on-hvm kexec:
add xs_reset_watches to shutdown watches from old kernel" hang when
run against oxenstored because it does not handle the unknown
XS_RESET_WATCHES operation and does not reply.

The symptom of this issue is a hang during boot at this point:
cpu 1 spinlock event irq 70
CPU 1 irqstacks, hard=dec94000 soft=dec96000
Booting Node 0, Processors #1
smpboot cpu 1: start_ip = 99000
Initializing CPU#1
installing Xen timer for CPU 1
Brought up 2 CPUs
Total of 2 processors activated (9625.99 BogoMIPS).
NET: Registered protocol family 16
<HANG>

This series makes oxenstored handle unknown operations by returning an
error indicating that the operation is unknown. I have not actually
implemented support for XS_RESET_WATCHES.

I also include a patch which I've been using for some time to enable
the use of oxenstored in preference to C xenstored when available.

Also included are two (more) little cleanup patches

Changes since v1:

* First two cleanup patches applied already
* Two more cleanup patches added
* Fixed warning in "handle unknown operations by returning an error to
the client"

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang [ In reply to ]

Ian.Campbell at citrix

Dec 15, 2011, 1:36 AM

Post #2 of 4 (126 views)

Permalink

Ian,

On Tue, 2011-12-13 at 16:12 +0000, Ian Campbell wrote:
> I also include a patch which I've been using for some time to enable
> the use of oxenstored in preference to C xenstored when available.

Can you also arrange for the test system to
collect /etc/xen/oxenstored.conf, /var/log/xenstored.conf*
and /var/log/xenstored-access.log* please.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang [ In reply to ]

Ian.Jackson at eu

Dec 15, 2011, 6:44 AM

Post #3 of 4 (131 views)

Permalink

Ian Campbell writes ("Re: [Xen-devel] [PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang"):
> On Tue, 2011-12-13 at 16:12 +0000, Ian Campbell wrote:
> > I also include a patch which I've been using for some time to enable
> > the use of oxenstored in preference to C xenstored when available.
>
> Can you also arrange for the test system to
> collect /etc/xen/oxenstored.conf, /var/log/xenstored.conf*
> and /var/log/xenstored-access.log* please.

I hadn't spotted these filenames in the source for oxenstored.
"/var/log/xenstored.conf*" ?! omg wtf bbq

Surely these should all be in /var/log/xen.

But I have added them to the list of files to be collected.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang [ In reply to ]

Ian.Campbell at citrix

Dec 15, 2011, 7:35 AM

Post #4 of 4 (145 views)

Permalink

On Thu, 2011-12-15 at 14:44 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 0 of 4 V2] oxenstored fixes -- fixes recent pvops kernel hang"):
> > On Tue, 2011-12-13 at 16:12 +0000, Ian Campbell wrote:
> > > I also include a patch which I've been using for some time to enable
> > > the use of oxenstored in preference to C xenstored when available.
> >
> > Can you also arrange for the test system to
> > collect /etc/xen/oxenstored.conf, /var/log/xenstored.conf*
> > and /var/log/xenstored-access.log* please.
>
> I hadn't spotted these filenames in the source for oxenstored.
> "/var/log/xenstored.conf*" ?! omg wtf bbq

Sorry, that's my typo, I meant /var/log/xenstored.log*. The .conf name
under /etc/xen is correct.

> Surely these should all be in /var/log/xen.

Could move them I guess. I'd like to hear from Jon and the XCP chaps
though. Patch would be the following, I think.

Ian.

diff -r 0ddea44c2a7f tools/ocaml/xenstored/logging.ml
--- a/tools/ocaml/xenstored/logging.ml Thu Dec 15 11:52:48 2011 +0000
+++ b/tools/ocaml/xenstored/logging.ml Thu Dec 15 15:35:39 2011 +0000
@@ -104,7 +104,7 @@ let string_of_date () =
tm.Unix.tm_hour tm.Unix.tm_min tm.Unix.tm_sec
(int_of_float (1000.0 *. msec))

-let xenstored_log_file = ref "/var/log/xenstored.log"
+let xenstored_log_file = ref "/var/log/xen/xenstored.log"
let xenstored_log_level = ref Warn
let xenstored_log_nb_files = ref 10
let xenstored_log_nb_lines = ref 13215
@@ -200,7 +200,7 @@ let sanitize_data data =
String.escaped data

let activate_access_log = ref true
-let access_log_file = ref "/var/log/xenstored-access.log"
+let access_log_file = ref "/var/log/xen/xenstored-access.log"
let access_log_nb_files = ref 20
let access_log_nb_lines = ref 13215
let access_log_nb_chars = ref 180
diff -r 0ddea44c2a7f tools/ocaml/xenstored/oxenstored.conf
--- a/tools/ocaml/xenstored/oxenstored.conf Thu Dec 15 11:52:48 2011 +0000
+++ b/tools/ocaml/xenstored/oxenstored.conf Thu Dec 15 15:35:39 2011 +0000
@@ -23,12 +23,12 @@ quota-transaction = 10
persistant = false

# Xenstored logs
-# xenstored-log-file = /var/log/xenstored.log
+# xenstored-log-file = /var/log/xen/xenstored.log
# xenstored-log-level = null
# xenstored-log-nb-files = 10

# Xenstored access logs
-# access-log-file = /var/log/xenstored-access.log
+# access-log-file = /var/log/xen/xenstored-access.log
# access-log-nb-lines = 13215
# acesss-log-nb-chars = 180
# access-log-special-ops = false

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel