Mailing List Archive: [PATCH 0 of 5] Memory sharing overhaul part 2

[PATCH 0 of 5] Memory sharing overhaul part 2

Dec 8, 2011, 5:54 AM

Post #1 of 5 (121 views)

(Sigh, the previous pachbomb got truncated by an smtp quota in my
provider... remaining patches in this series)

This patch series proposes an overhaul of the memory sharing code.

Aside from bug fixes and cleanups, the main features are:
- Polling of stats via libxc, libxl and console
- Removal of global sharing hashtable and global sharing lock
(if audit disabled)
- Turned sharing audits into a domctl
- New domctl to populate vacant physmap entries with shared
pages.

As a result, the domctl interface to sharing changes. The only in-tree
consumer of this interface is updated in the current series. It is
important that if any out-of-tree consumer exists, that they state
their opinion on this interface change.

Patches 5 to 8, 10, 11, 15 and 18 are tools patches.

Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Signed-off-by: Adin Scannell <adin@scannell.ca>

xen/arch/x86/mm/mem_sharing.c | 106 ++++++++++++++++++++++++++++++++++++++++++
xen/include/public/domctl.h | 3 +-
tools/libxc/xc_memshr.c | 23 +++++++++
tools/libxc/xenctrl.h | 6 ++
xen/arch/ia64/xen/mm.c | 6 ++
xen/arch/x86/mm/mem_sharing.c | 8 +++
xen/common/keyhandler.c | 7 +-
xen/include/xen/mm.h | 3 +
xen/arch/x86/mm/mem_sharing.c | 17 ++++-
xen/include/public/domctl.h | 1 +
tools/libxc/xc_memshr.c | 14 +++++
tools/libxc/xenctrl.h | 2 +
12 files changed, 188 insertions(+), 8 deletions(-)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 5] Memory sharing overhaul part 2 [ In reply to ]

JBeulich at suse

Dec 8, 2011, 6:40 AM

Post #2 of 5 (115 views)

Permalink

>>> On 08.12.11 at 14:54, Andres Lagar-Cavilla <andres@lagarcavilla.org> wrote:
>...
> xen/arch/x86/mm/mem_sharing.c | 106 ++++++++++++++++++++++++++++++++++++++++++
> xen/include/public/domctl.h | 3 +-
> tools/libxc/xc_memshr.c | 23 +++++++++
> tools/libxc/xenctrl.h | 6 ++
> xen/arch/ia64/xen/mm.c | 6 ++
> xen/arch/x86/mm/mem_sharing.c | 8 +++
> xen/common/keyhandler.c | 7 +-
> xen/include/xen/mm.h | 3 +
> xen/arch/x86/mm/mem_sharing.c | 17 ++++-
> xen/include/public/domctl.h | 1 +
> tools/libxc/xc_memshr.c | 14 +++++
> tools/libxc/xenctrl.h | 2 +
> 12 files changed, 188 insertions(+), 8 deletions(-)

As this isn't the first time with your patch submissions - I'm not sure what
you use to generate these stats, but in order to be useful I would
generally expect this to be a list with duplicate entries folded rather than
a mere concatenation of those from the individual patches (leaving doing
the arithmetic to the reader/reviewer).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 5] Memory sharing overhaul part 2 [ In reply to ]

JBeulich at suse

Dec 8, 2011, 6:46 AM

Post #3 of 5 (121 views)

Permalink

>>> On 08.12.11 at 14:54, Andres Lagar-Cavilla <andres@lagarcavilla.org> wrote:
> (Sigh, the previous pachbomb got truncated by an smtp quota in my
> provider... remaining patches in this series)

But you also didn't re-write the description for this shorter series:

> This patch series proposes an overhaul of the memory sharing code.
>
> Aside from bug fixes and cleanups, the main features are:

I wasn't able to spot any bug fixes or cleanups, and apart from
patch 3 all others merely add dead code. I'm therefore tempted to
nak 1, 2, 4, and 5 unless you come forward with code that actually
uses these new bits.

> - Polling of stats via libxc, libxl and console
> - Removal of global sharing hashtable and global sharing lock
> (if audit disabled)
> - Turned sharing audits into a domctl
> - New domctl to populate vacant physmap entries with shared
> pages.
>
> As a result, the domctl interface to sharing changes. The only in-tree
> consumer of this interface is updated in the current series. It is
> important that if any out-of-tree consumer exists, that they state
> their opinion on this interface change.
>
> Patches 5 to 8, 10, 11, 15 and 18 are tools patches.

There's no patch 8 and higher here.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 5] Memory sharing overhaul part 2 [ In reply to ]

andres at lagarcavilla

Dec 8, 2011, 8:05 AM

Post #4 of 5 (115 views)

Permalink

>>>> On 08.12.11 at 14:54, Andres Lagar-Cavilla <andres@lagarcavilla.org>
>>>> wrote:
>>...
>> xen/arch/x86/mm/mem_sharing.c | 106
>> ++++++++++++++++++++++++++++++++++++++++++
>> xen/include/public/domctl.h | 3 +-
>> tools/libxc/xc_memshr.c | 23 +++++++++
>> tools/libxc/xenctrl.h | 6 ++
>> xen/arch/ia64/xen/mm.c | 6 ++
>> xen/arch/x86/mm/mem_sharing.c | 8 +++
>> xen/common/keyhandler.c | 7 +-
>> xen/include/xen/mm.h | 3 +
>> xen/arch/x86/mm/mem_sharing.c | 17 ++++-
>> xen/include/public/domctl.h | 1 +
>> tools/libxc/xc_memshr.c | 14 +++++
>> tools/libxc/xenctrl.h | 2 +
>> 12 files changed, 188 insertions(+), 8 deletions(-)
>
> As this isn't the first time with your patch submissions - I'm not sure
> what
> you use to generate these stats, but in order to be useful I would
> generally expect this to be a list with duplicate entries folded rather
> than
> a mere concatenation of those from the individual patches (leaving doing
> the arithmetic to the reader/reviewer).
I apologize. I am also frustrated by this. Hugely.
Andres
>
> Jan
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 0 of 5] Memory sharing overhaul part 2 [ In reply to ]

tim at xen

Dec 8, 2011, 2:40 PM

Post #5 of 5 (114 views)

Permalink

At 08:54 -0500 on 08 Dec (1323334476), Andres Lagar-Cavilla wrote:
> (Sigh, the previous pachbomb got truncated by an smtp quota in my
> provider... remaining patches in this series)

I only got up to #12/18 in the previous round, so by my count I'm still
one short.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel