Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Xen>
  3. Devel
[PATCH] vvmx: fix intended assignment
JBeulich at suse
Dec 1, 2011, 2:51 AM
Post #1 of 5 (165 views)
Permalink
From what I can tell, this was supposed to be an assignment (not warned
about by the compiler due to -Wno-unused, which is about to be removed).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -581,7 +581,7 @@ static void nvmx_purge_vvmcs(struct vcpu
__clear_current_vvmcs(v);
if ( nvcpu->nv_vvmcxaddr != VMCX_EADDR )
hvm_unmap_guest_frame(nvcpu->nv_vvmcx);
- nvcpu->nv_vvmcx == NULL;
+ nvcpu->nv_vvmcx = NULL;
nvcpu->nv_vvmcxaddr = VMCX_EADDR;
for (i=0; i<2; i++) {
if ( nvmx->iobitmap[i] ) {

Attached Files:

Re: [PATCH] vvmx: fix intended assignment [ In reply to ]
haitao.shan at intel
Dec 1, 2011, 3:19 AM
Post #2 of 5 (167 views)
Permalink
Hi, Jan,

I think you cannot cc He Qing any more. As He Qing (who had done some work
on nested) has left Intel, while this email address is going to another
people who just has the same name.

Shan Haitao

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> bounces@lists.xensource.com] On Behalf Of Jan Beulich
> Sent: Thursday, December 01, 2011 6:51 PM
> To: xen-devel@lists.xensource.com
> Cc: Dong, Eddie; Tim Deegan; He, Qing
> Subject: [Xen-devel] [PATCH] vvmx: fix intended assignment
>
> From what I can tell, this was supposed to be an assignment (not warned
> about by the compiler due to -Wno-unused, which is about to be removed).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -581,7 +581,7 @@ static void nvmx_purge_vvmcs(struct vcpu
> __clear_current_vvmcs(v);
> if ( nvcpu->nv_vvmcxaddr != VMCX_EADDR )
> hvm_unmap_guest_frame(nvcpu->nv_vvmcx);
> - nvcpu->nv_vvmcx == NULL;
> + nvcpu->nv_vvmcx = NULL;
> nvcpu->nv_vvmcxaddr = VMCX_EADDR;
> for (i=0; i<2; i++) {
> if ( nvmx->iobitmap[i] ) {
>
>

Attached Files:

Re: [PATCH] vvmx: fix intended assignment [ In reply to ]
tim at xen
Dec 1, 2011, 7:43 AM
Post #3 of 5 (163 views)
Permalink
At 10:51 +0000 on 01 Dec (1322736677), Jan Beulich wrote:
> From what I can tell, this was supposed to be an assignment (not warned
> about by the compiler due to -Wno-unused, which is about to be removed).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -581,7 +581,7 @@ static void nvmx_purge_vvmcs(struct vcpu
> __clear_current_vvmcs(v);
> if ( nvcpu->nv_vvmcxaddr != VMCX_EADDR )
> hvm_unmap_guest_frame(nvcpu->nv_vvmcx);
> - nvcpu->nv_vvmcx == NULL;
> + nvcpu->nv_vvmcx = NULL;
> nvcpu->nv_vvmcxaddr = VMCX_EADDR;
> for (i=0; i<2; i++) {
> if ( nvmx->iobitmap[i] ) {
>
>
>

Applied, thanks.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: [PATCH] vvmx: fix intended assignment [ In reply to ]
pasik at iki
Dec 1, 2011, 10:06 AM
Post #4 of 5 (152 views)
Permalink
On Thu, Dec 01, 2011 at 07:19:58PM +0800, Shan, Haitao wrote:
> Hi, Jan,
>

Hello,

> I think you cannot cc He Qing any more. As He Qing (who had done some work
> on nested) has left Intel, while this email address is going to another
> people who just has the same name.
>

Is there anyone from Intel currently working on nested virt?

-- Pasi

> Shan Haitao
>
> > -----Original Message-----
> > From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> > bounces@lists.xensource.com] On Behalf Of Jan Beulich
> > Sent: Thursday, December 01, 2011 6:51 PM
> > To: xen-devel@lists.xensource.com
> > Cc: Dong, Eddie; Tim Deegan; He, Qing
> > Subject: [Xen-devel] [PATCH] vvmx: fix intended assignment
> >
> > From what I can tell, this was supposed to be an assignment (not warned
> > about by the compiler due to -Wno-unused, which is about to be removed).
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> > --- a/xen/arch/x86/hvm/vmx/vvmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> > @@ -581,7 +581,7 @@ static void nvmx_purge_vvmcs(struct vcpu
> > __clear_current_vvmcs(v);
> > if ( nvcpu->nv_vvmcxaddr != VMCX_EADDR )
> > hvm_unmap_guest_frame(nvcpu->nv_vvmcx);
> > - nvcpu->nv_vvmcx == NULL;
> > + nvcpu->nv_vvmcx = NULL;
> > nvcpu->nv_vvmcxaddr = VMCX_EADDR;
> > for (i=0; i<2; i++) {
> > if ( nvmx->iobitmap[i] ) {
> >
> >
>



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: [PATCH] vvmx: fix intended assignment [ In reply to ]
haitao.shan at intel
Dec 1, 2011, 7:11 PM
Post #5 of 5 (159 views)
Permalink
You can still contact Dong Eddie for nested virtualization topics.

Shan Haitao

> -----Original Message-----
> From: Pasi Kärkkäinen [mailto:pasik@iki.fi]
> Sent: Friday, December 02, 2011 2:07 AM
> To: Shan, Haitao
> Cc: Jan Beulich; xen-devel@lists.xensource.com; Dong, Eddie; Tim Deegan;
> He, Qing
> Subject: Re: [Xen-devel] [PATCH] vvmx: fix intended assignment
>
> On Thu, Dec 01, 2011 at 07:19:58PM +0800, Shan, Haitao wrote:
> > Hi, Jan,
> >
>
> Hello,
>
> > I think you cannot cc He Qing any more. As He Qing (who had done some
> > work on nested) has left Intel, while this email address is going to
> > another people who just has the same name.
> >
>
> Is there anyone from Intel currently working on nested virt?
>
> -- Pasi
>
> > Shan Haitao
> >
> > > -----Original Message-----
> > > From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> > > bounces@lists.xensource.com] On Behalf Of Jan Beulich
> > > Sent: Thursday, December 01, 2011 6:51 PM
> > > To: xen-devel@lists.xensource.com
> > > Cc: Dong, Eddie; Tim Deegan; He, Qing
> > > Subject: [Xen-devel] [PATCH] vvmx: fix intended assignment
> > >
> > > From what I can tell, this was supposed to be an assignment (not
> > > warned about by the compiler due to -Wno-unused, which is about to be
> removed).
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > >
> > > --- a/xen/arch/x86/hvm/vmx/vvmx.c
> > > +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> > > @@ -581,7 +581,7 @@ static void nvmx_purge_vvmcs(struct vcpu
> > > __clear_current_vvmcs(v);
> > > if ( nvcpu->nv_vvmcxaddr != VMCX_EADDR )
> > > hvm_unmap_guest_frame(nvcpu->nv_vvmcx);
> > > - nvcpu->nv_vvmcx == NULL;
> > > + nvcpu->nv_vvmcx = NULL;
> > > nvcpu->nv_vvmcxaddr = VMCX_EADDR;
> > > for (i=0; i<2; i++) {
> > > if ( nvmx->iobitmap[i] ) {
> > >
> > >
> >
>
>
>
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel

Attached Files:

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal