Mailing List Archive: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests

[PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests

Oct 23, 2011, 12:07 PM

Post #1 of 6 (262 views)

Added configuration support to enable debug information
for KVM Guests in debugfs

Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Suzuki Poulose <suzuki@in.ibm.com>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
---
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 1f03f82..ed34269 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -562,6 +562,15 @@ config KVM_GUEST
This option enables various optimizations for running under the KVM
hypervisor.

+config KVM_DEBUG_FS
+ bool "Enable debug information for KVM Guests in debugfs"
+ depends on KVM_GUEST
+ default n
+ ---help---
+ This option enables collection of various statistics for KVM guest.
+ Statistics are displayed in debugfs filesystem. Enabling this option
+ may incur significant overhead.
+
source "arch/x86/lguest/Kconfig"

config PARAVIRT

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests [ In reply to ]

levinsasha928 at gmail

Oct 24, 2011, 3:01 AM

Post #2 of 6 (216 views)

Permalink

On Mon, 2011-10-24 at 00:37 +0530, Raghavendra K T wrote:
> Added configuration support to enable debug information
> for KVM Guests in debugfs
>
> Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
> Signed-off-by: Suzuki Poulose <suzuki@in.ibm.com>
> Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
> ---
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1f03f82..ed34269 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -562,6 +562,15 @@ config KVM_GUEST
> This option enables various optimizations for running under the KVM
> hypervisor.
>
> +config KVM_DEBUG_FS
> + bool "Enable debug information for KVM Guests in debugfs"
> + depends on KVM_GUEST

Shouldn't it depend on DEBUG_FS as well?

> + default n
> + ---help---
> + This option enables collection of various statistics for KVM guest.
> + Statistics are displayed in debugfs filesystem. Enabling this option
> + may incur significant overhead.
> +
> source "arch/x86/lguest/Kconfig"
>
> config PARAVIRT

--

Sasha.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests [ In reply to ]

avi at redhat

Oct 24, 2011, 3:15 AM

Post #3 of 6 (224 views)

Permalink

On 10/23/2011 09:07 PM, Raghavendra K T wrote:
> Added configuration support to enable debug information
> for KVM Guests in debugfs
>
> Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
> Signed-off-by: Suzuki Poulose <suzuki@in.ibm.com>
> Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
> ---
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1f03f82..ed34269 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -562,6 +562,15 @@ config KVM_GUEST
> This option enables various optimizations for running under the KVM
> hypervisor.
>
> +config KVM_DEBUG_FS
> + bool "Enable debug information for KVM Guests in debugfs"
> + depends on KVM_GUEST
> + default n
> + ---help---
> + This option enables collection of various statistics for KVM guest.
> + Statistics are displayed in debugfs filesystem. Enabling this option
> + may incur significant overhead.
> +
> source "arch/x86/lguest/Kconfig"
>
>

This might be better implemented through tracepoints, which an be
enabled dynamically.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests [ In reply to ]

raghukt at linux

Oct 24, 2011, 11:45 AM

Post #4 of 6 (221 views)

Permalink

On 10/24/2011 03:31 PM, Sasha Levin wrote:
> On Mon, 2011-10-24 at 00:37 +0530, Raghavendra K T wrote:
>> Added configuration support to enable debug information
>> for KVM Guests in debugfs
>> +config KVM_DEBUG_FS
>> + bool "Enable debug information for KVM Guests in debugfs"
>> + depends on KVM_GUEST
>
> Shouldn't it depend on DEBUG_FS as well?
Thanks again for pointing. will correct this too.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests [ In reply to ]

raghukt at linux

Oct 25, 2011, 11:11 AM

Post #5 of 6 (216 views)

Permalink

On 10/24/2011 03:45 PM, Avi Kivity wrote:
> On 10/23/2011 09:07 PM, Raghavendra K T wrote:
>> Added configuration support to enable debug information
>> for KVM Guests in debugfs
>>
>> Signed-off-by: Srivatsa Vaddagiri<vatsa@linux.vnet.ibm.com>
>> Signed-off-by: Suzuki Poulose<suzuki@in.ibm.com>
>> Signed-off-by: Raghavendra K T<raghavendra.kt@linux.vnet.ibm.com>
>> ---
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 1f03f82..ed34269 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -562,6 +562,15 @@ config KVM_GUEST
>> This option enables various optimizations for running under the KVM
>> hypervisor.
>>
>> +config KVM_DEBUG_FS
>> + bool "Enable debug information for KVM Guests in debugfs"
>> + depends on KVM_GUEST
>> + default n
>> + ---help---
>> + This option enables collection of various statistics for KVM guest.
>> + Statistics are displayed in debugfs filesystem. Enabling this option
>> + may incur significant overhead.
>> +
>> source "arch/x86/lguest/Kconfig"
>>
>>
>
> This might be better implemented through tracepoints, which an be
> enabled dynamically.
>
Interesting option. I 'll explore this one. Thanks for pointing.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests [ In reply to ]

jeremy at goop

Oct 25, 2011, 11:30 AM

Post #6 of 6 (219 views)

Permalink

On 10/24/2011 03:15 AM, Avi Kivity wrote:
> On 10/23/2011 09:07 PM, Raghavendra K T wrote:
>> Added configuration support to enable debug information
>> for KVM Guests in debugfs
>>
>> Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>> Signed-off-by: Suzuki Poulose <suzuki@in.ibm.com>
>> Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
>> ---
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 1f03f82..ed34269 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -562,6 +562,15 @@ config KVM_GUEST
>> This option enables various optimizations for running under the KVM
>> hypervisor.
>>
>> +config KVM_DEBUG_FS
>> + bool "Enable debug information for KVM Guests in debugfs"
>> + depends on KVM_GUEST
>> + default n
>> + ---help---
>> + This option enables collection of various statistics for KVM guest.
>> + Statistics are displayed in debugfs filesystem. Enabling this option
>> + may incur significant overhead.
>> +
>> source "arch/x86/lguest/Kconfig"
>>
>>
> This might be better implemented through tracepoints, which an be
> enabled dynamically.

Tracepoints use spinlocks, so that could get awkward.

J

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel