Mailing List Archive

use of struct hvm_irq_dpci in pv guests
The per-domain pointer to this is stored in ->arch.hvm_domain.irq.dpci,
hence suggesting that this is a HVM only field.
do_domctl(XEN_DOMCTL_bind_pt_irq) and domain_get_irq_dpci()
access it however without considering HVM-ness. In the course of
splitting/shrinking struct domain, I'd therefore need to know whether
this field ought to become common, or whether all accessors of the
field need to get protected by is_hvm_domain().

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: use of struct hvm_irq_dpci in pv guests [ In reply to ]
Hi, Jan,

I think it should be protected by is_hvm_domain(). Anyway, I have saw your
patches already in upstream Xen.

Shan Haitao

2011/3/31 Jan Beulich <JBeulich@novell.com>

> The per-domain pointer to this is stored in ->arch.hvm_domain.irq.dpci,
> hence suggesting that this is a HVM only field.
> do_domctl(XEN_DOMCTL_bind_pt_irq) and domain_get_irq_dpci()
> access it however without considering HVM-ness. In the course of
> splitting/shrinking struct domain, I'd therefore need to know whether
> this field ought to become common, or whether all accessors of the
> field need to get protected by is_hvm_domain().
>
> Thanks, Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>