Mailing List Archive

On 03/16/11 14:50, Juergen Gross wrote:
> Hi,
>
> I've just set up a machine with OpenSuse 11.4 and tried to build Xen.
>
> Under root I did:
>
> hg clone http://xenbits.xensource.com/xen-unstable.hg
> cd xen-unstable.hg
> make xen
>
> The make failed with:
>
> make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> RELOC=0x7c000 make -f build32.mk reloc.S
> make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> make[5]: *** ../../../../.config: Is a directory. Stop.
> make[5]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> make[4]: *** [reloc.S] Error 2
> make[4]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> make[3]: *** [/root/xen-unstable.hg/xen/arch/x86/boot/built_in.o] Error 2
> make[3]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86'
> make[2]: *** [/root/xen-unstable.hg/xen/xen] Error 2
> make[2]: Leaving directory `/root/xen-unstable.hg/xen'
> make[1]: *** [install] Error 2
> make[1]: Leaving directory `/root/xen-unstable.hg/xen'
> make: *** [install-xen] Error 2
>
> The reason seems to be a directory /root/.config which isn't present on my
> other machines.

And /.config as well.

>
> make tools
>
> fails in a similar way. Many Makefiles seem to contain lines like:
>
> XEN_ROOT=../..
>
> which is a really bad idea in my opinion. XEN_ROOT should only be set,
> if it
> is not yet defined.
>
> I'd suggest to use
>
> XEN_ROOT ?= $(PWD)/../..

should be $(CURDIR), of course.

>
> instead. A patch is easily made, but affects ca. 100 Makefiles. And this
> change could break the possibility to just do a "make" in a subdirectory.

The patch isn't really easy, as more seems to go wrong.
I've changed some Makefiles and get now with "make tools":

make[4]: Leaving directory `/root/xen-unstable.hg/tools/include/xen-foreign'
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/arch-ia64
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/arch-ia64/hvm
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/arch-x86
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/arch-x86/hvm
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/foreign
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/hvm
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/io
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/sys
/root/xen-unstable.hg/tools/cross-install -d -m0755 -p
/root/xen-unstable.hg/dist/install/usr/include/xen/xsm
/root/xen-unstable.hg/tools/cross-install -m0644 -p xen/COPYING
/root/xen-unstable.hg/dist/install/usr/include/xen
install: cannot stat `xen/COPYING': No such file or directory
make[3]: *** [install] Error 1
make[3]: Leaving directory `/root/xen-unstable.hg/tools/include'
make[2]: *** [subdir-install-include] Error 2
make[2]: Leaving directory `/root/xen-unstable.hg/tools'
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/root/xen-unstable.hg/tools'
make: *** [install-tools] Error 2


Juergen

--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 16/03/2011 13:50, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:

> Hi,
>
> I've just set up a machine with OpenSuse 11.4 and tried to build Xen.
>
> Under root I did:
>
> hg clone http://xenbits.xensource.com/xen-unstable.hg
> cd xen-unstable.hg
> make xen
>
> The make failed with:
>
> make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> RELOC=0x7c000 make -f build32.mk reloc.S
> make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> make[5]: *** ../../../../.config: Is a directory. Stop.

Seems to me that /root/xen-unstable.hg/xen/arch/x86/boot/../../../../.config
resolves to /root/xen-unstable.hg/.config. Which is what is intended. Also I
tried creating a .config dir just outside my own xen-unstable repo, and
rebuoilding the hypervisor, and it works okay for me.

> The reason seems to be a directory /root/.config which isn't present on my
> other machines.

We shouldn't be referring outside the repository. AFAICS the above logging
doesn't indicate that we are. I don't understand why you are getting that
error. I haven't been able to reproduce it.

> fails in a similar way. Many Makefiles seem to contain lines like:
>
> XEN_ROOT=../..
>
> which is a really bad idea in my opinion. XEN_ROOT should only be set, if it
> is not yet defined.

Why? It's private to our build system. We don't want the user screwing with
it. I also don't see why relative paths within our repository should be
avoided, as you try to do in your alternative formulation.

-- Keir

> I'd suggest to use
>
> XEN_ROOT ?= $(PWD)/../..
>
> instead. A patch is easily made, but affects ca. 100 Makefiles. And this
> change could break the possibility to just do a "make" in a subdirectory.
>
> Opinions?
>
>
> Juergen



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 03/16/11 17:50, Keir Fraser wrote:
> On 16/03/2011 13:50, "Juergen Gross"<juergen.gross@ts.fujitsu.com> wrote:
>
>> Hi,
>>
>> I've just set up a machine with OpenSuse 11.4 and tried to build Xen.
>>
>> Under root I did:
>>
>> hg clone http://xenbits.xensource.com/xen-unstable.hg
>> cd xen-unstable.hg
>> make xen
>>
>> The make failed with:
>>
>> make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
>> RELOC=0x7c000 make -f build32.mk reloc.S
>> make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
>> make[5]: *** ../../../../.config: Is a directory. Stop.
>
> Seems to me that /root/xen-unstable.hg/xen/arch/x86/boot/../../../../.config
> resolves to /root/xen-unstable.hg/.config. Which is what is intended. Also I
> tried creating a .config dir just outside my own xen-unstable repo, and
> rebuoilding the hypervisor, and it works okay for me.

Okay, I checked it.
My build environment is under /root/xen-unstable.hg
I have .config directories in / and in /root
I created .config files on another machine without those directories in / and
in /root with a make error statement indicating which file is used:

make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
RELOC=0x7c000 make -f build32.mk reloc.S
make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
../../../../.config:1: *** error form /.config. Stop.
make[5]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86/boot'
make[4]: *** [reloc.S] Error 2
make[4]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86/boot'
make[3]: *** [/root/xen-unstable.hg/xen/arch/x86/boot/built_in.o] Error 2
make[3]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/root/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/root/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/root/xen-unstable.hg/xen'
make: *** [install-xen] Error 2


The reason is clear: XEN_ROOT is set to a *relative* path. And when make is
including a Makefile, it switches the working directory to the directory of
the included Makefile. Including another Makefile via XEN_ROOT then is the
problem...

>
>> The reason seems to be a directory /root/.config which isn't present on my
>> other machines.
>
> We shouldn't be referring outside the repository. AFAICS the above logging
> doesn't indicate that we are. I don't understand why you are getting that
> error. I haven't been able to reproduce it.

I have :-(

>
>> fails in a similar way. Many Makefiles seem to contain lines like:
>>
>> XEN_ROOT=../..
>>
>> which is a really bad idea in my opinion. XEN_ROOT should only be set, if it
>> is not yet defined.
>
> Why? It's private to our build system. We don't want the user screwing with
> it. I also don't see why relative paths within our repository should be
> avoided, as you try to do in your alternative formulation.

You have to avoid relative paths in make variables used in different directory
levels.


Juergen

--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17/03/2011 05:52, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:

> The reason is clear: XEN_ROOT is set to a *relative* path. And when make is
> including a Makefile, it switches the working directory to the directory of
> the included Makefile. Including another Makefile via XEN_ROOT then is the
> problem...

Well it's not clear to me. In my tests, including another Makefile does not
change the working directory, only recursive make with -C specified does
that. That seems logical -- pulling in standard rules containing wildcard
globs would otherwise have unpredictable results, if the wildcards were
evaluated in the directory of the included Makefile.

In your case, if Config.mk was getting run with incorrect relative XEN_ROOT,
how would the earlier include lines in that file work? You are getting an
error on '-include $(XEN_ROOT)/.config', but there are earlier (and
unconditional!) include lines in Config.mk that also reference XEN_ROOT. I
suppose they must be working.

So I think something is weird in your environment, or your make is broken.
However in this one specific failure case I can avoid redefining XEN_ROOT
outside xen/Makefile, since all hypervisor builds start at that Makefile. So
you can see whether c/s 23048 in xen-unstable staging fixes your build. I
applied it as it happens to be a teeny tiny cleanup as well.

-- Keir

>>
>>> The reason seems to be a directory /root/.config which isn't present on my
>>> other machines.
>>
>> We shouldn't be referring outside the repository. AFAICS the above logging
>> doesn't indicate that we are. I don't understand why you are getting that
>> error. I haven't been able to reproduce it.
>
> I have :-(
>
>>
>>> fails in a similar way. Many Makefiles seem to contain lines like:
>>>
>>> XEN_ROOT=../..
>>>
>>> which is a really bad idea in my opinion. XEN_ROOT should only be set, if it
>>> is not yet defined.
>>
>> Why? It's private to our build system. We don't want the user screwing with
>> it. I also don't see why relative paths within our repository should be
>> avoided, as you try to do in your alternative formulation.
>
> You have to avoid relative paths in make variables used in different directory
> levels.
>
>
> Juergen



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 03/17/11 09:11, Keir Fraser wrote:
> On 17/03/2011 05:52, "Juergen Gross"<juergen.gross@ts.fujitsu.com> wrote:
>
>> The reason is clear: XEN_ROOT is set to a *relative* path. And when make is
>> including a Makefile, it switches the working directory to the directory of
>> the included Makefile. Including another Makefile via XEN_ROOT then is the
>> problem...
>
> Well it's not clear to me. In my tests, including another Makefile does not
> change the working directory, only recursive make with -C specified does
> that. That seems logical -- pulling in standard rules containing wildcard
> globs would otherwise have unpredictable results, if the wildcards were
> evaluated in the directory of the included Makefile.
>
> In your case, if Config.mk was getting run with incorrect relative XEN_ROOT,
> how would the earlier include lines in that file work? You are getting an
> error on '-include $(XEN_ROOT)/.config', but there are earlier (and
> unconditional!) include lines in Config.mk that also reference XEN_ROOT. I
> suppose they must be working.
>
> So I think something is weird in your environment, or your make is broken.
> However in this one specific failure case I can avoid redefining XEN_ROOT
> outside xen/Makefile, since all hypervisor builds start at that Makefile. So
> you can see whether c/s 23048 in xen-unstable staging fixes your build. I
> applied it as it happens to be a teeny tiny cleanup as well.

We are both right :-)

I created /.config with:

$(warning /.config: $(MAKEFILE_LIST))

and got the following with "make tools":

make -C tools install
make[1]: Entering directory `/root/xen-unstable.hg/tools'
make[2]: Entering directory `/root/xen-unstable.hg/tools'
make -C check install
make[3]: Entering directory `/root/xen-unstable.hg/tools/check'
../../.config:1: /.config: Makefile ../../tools/Rules.mk ../../Config.mk
../../config/Linux.mk ../../config/StdGNU.mk ../../config/x86_64.mk
/usr/include/../../.config


So the problem is not changing the working directory, but implicit directory
search. $(XEN_ROOT)/.config expands as ../../.config and this file was not
found, so make searches in /usr/include, as the file path is relative. And
/usr/include/../../.config results as /.config :-(

The problem is still the relative XEN_ROOT specification.
Or the missing .config under XEN_ROOT, so creating this file solves my
problem. :-)


Juergen

--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On 17.03.11 at 09:59, Juergen Gross <juergen.gross@ts.fujitsu.com> wrote:
> The problem is still the relative XEN_ROOT specification.
> Or the missing .config under XEN_ROOT, so creating this file solves my
> problem. :-)

I'd favor the latter, e.g. by adding something like

cfg-create := $(shell touch $(XEN_ROOT)/.config)

to ./Config.mk, or putting the include in a conditional instead
of making use of -include. It seems to me that "-include" doing a
default directory search just like "include" does wasn't the best
behavioral decision by the make authors - if one really wants to
include nothing, one just cannot use this to avoid the conditional
(which is what so far I thought was the main advantage of the
"-" prefix).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 03/17/11 11:13, Jan Beulich wrote:
>>>> On 17.03.11 at 09:59, Juergen Gross<juergen.gross@ts.fujitsu.com> wrote:
>> The problem is still the relative XEN_ROOT specification.
>> Or the missing .config under XEN_ROOT, so creating this file solves my
>> problem. :-)
>
> I'd favor the latter, e.g. by adding something like
>
> cfg-create := $(shell touch $(XEN_ROOT)/.config)
>
> to ./Config.mk, or putting the include in a conditional instead
> of making use of -include.

As short time measure this seems to be okay.

On the long run I'd prefer to use absolute paths only. Otherwise you've
always a risk to use something from outside the intended build environment.

XEN_ROOT = $(abspath ../..)

seems not too hard to use instead of

XEN_ROOT = ../..

And I'm still favoring usage of conditional setting of XEN_ROOT in included
Makefiles other than config/* to avoid hard to find problems.


Juergen

--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17/03/2011 08:59, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:

> So the problem is not changing the working directory, but implicit directory
> search. $(XEN_ROOT)/.config expands as ../../.config and this file was not
> found, so make searches in /usr/include, as the file path is relative. And
> /usr/include/../../.config results as /.config :-(
>
> The problem is still the relative XEN_ROOT specification.
> Or the missing .config under XEN_ROOT, so creating this file solves my
> problem. :-)

Okay then the relative XEN_ROOT specifications are a problem. Fixed as c/s
23049.

-- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On 17.03.11 at 11:29, Juergen Gross <juergen.gross@ts.fujitsu.com> wrote:
> On 03/17/11 11:13, Jan Beulich wrote:
>>>>> On 17.03.11 at 09:59, Juergen Gross<juergen.gross@ts.fujitsu.com> wrote:
>>> The problem is still the relative XEN_ROOT specification.
>>> Or the missing .config under XEN_ROOT, so creating this file solves my
>>> problem. :-)
>>
>> I'd favor the latter, e.g. by adding something like
>>
>> cfg-create := $(shell touch $(XEN_ROOT)/.config)
>>
>> to ./Config.mk, or putting the include in a conditional instead
>> of making use of -include.
>
> As short time measure this seems to be okay.
>
> On the long run I'd prefer to use absolute paths only. Otherwise you've
> always a risk to use something from outside the intended build environment.
>
> XEN_ROOT = $(abspath ../..)
>
> seems not too hard to use instead of
>
> XEN_ROOT = ../..

Except that make 3.80 doesn't support this, and that make version
is - to my knowledge - still in quite wide spread use. But that can
probably be overcome with a fallback implementation (which newer
make just wouldn't use).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17/03/2011 10:48, "Jan Beulich" <JBeulich@novell.com> wrote:

>> As short time measure this seems to be okay.
>>
>> On the long run I'd prefer to use absolute paths only. Otherwise you've
>> always a risk to use something from outside the intended build environment.
>>
>> XEN_ROOT = $(abspath ../..)
>>
>> seems not too hard to use instead of
>>
>> XEN_ROOT = ../..
>
> Except that make 3.80 doesn't support this, and that make version
> is - to my knowledge - still in quite wide spread use. But that can
> probably be overcome with a fallback implementation (which newer
> make just wouldn't use).

It has CURDIR, so we can just use that. Which is what I've done. It's also
cleaned up some not-nice bit of build-fu which were prefixing a relative
XEN_ROOT with arbitrary extra ../'s to "make things work".

-- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel