Mailing List Archive

linux: arch/i386/pci/irq-xen.c state
Is there any reason other than it being an oversight that these two
hunks (from patch-2.6.18.8)

diff --git a/arch/i386/pci/irq.c b/arch/i386/pci/irq.c
index 4a8995c..65a2ce8 100644
--- a/arch/i386/pci/irq.c
+++ b/arch/i386/pci/irq.c
@@ -255,13 +255,13 @@ static int pirq_via_set(struct pci_dev *router, struct pci_dev *dev, int pirq, i
*/
static int pirq_via586_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
{
- static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
+ static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
return read_config_nybble(router, 0x55, pirqmap[pirq-1]);
}

static int pirq_via586_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
{
- static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
+ static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
write_config_nybble(router, 0x55, pirqmap[pirq-1], irq);
return 1;
}

is not mirrored to the Xen version of the file?

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: linux: arch/i386/pci/irq-xen.c state [ In reply to ]
I rather doubt it! Please send a patch to fix it up.

-- Keir

On 28/2/08 16:26, "Jan Beulich" <jbeulich@novell.com> wrote:

> Is there any reason other than it being an oversight that these two
> hunks (from patch-2.6.18.8)
>
> diff --git a/arch/i386/pci/irq.c b/arch/i386/pci/irq.c
> index 4a8995c..65a2ce8 100644
> --- a/arch/i386/pci/irq.c
> +++ b/arch/i386/pci/irq.c
> @@ -255,13 +255,13 @@ static int pirq_via_set(struct pci_dev *router, struct
> pci_dev *dev, int pirq, i
> */
> static int pirq_via586_get(struct pci_dev *router, struct pci_dev *dev, int
> pirq)
> {
> - static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
> + static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
> return read_config_nybble(router, 0x55, pirqmap[pirq-1]);
> }
>
> static int pirq_via586_set(struct pci_dev *router, struct pci_dev *dev, int
> pirq, int irq)
> {
> - static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
> + static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
> write_config_nybble(router, 0x55, pirqmap[pirq-1], irq);
> return 1;
> }
>
> is not mirrored to the Xen version of the file?
>
> Thanks, Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel