Mailing List Archive

commit 445f66fe00a0a899610bd9217c796721d0054a94
Author: Nicola Vetrini <nicola.vetrini@bugseng.com>
AuthorDate: Thu Apr 25 09:51:13 2024 +0200
Commit: Jan Beulich <jbeulich@suse.com>
CommitDate: Thu Apr 25 09:51:13 2024 +0200

x86/debugreg: address violation of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
xen/arch/x86/include/asm/debugreg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/include/asm/debugreg.h b/xen/arch/x86/include/asm/debugreg.h
index 2bdaf5d9aa..96c406ad53 100644
--- a/xen/arch/x86/include/asm/debugreg.h
+++ b/xen/arch/x86/include/asm/debugreg.h
@@ -67,7 +67,7 @@
#define DR_GENERAL_DETECT (0x00002000UL) /* General detect enable */

#define write_debugreg(reg, val) do { \
- unsigned long __val = val; \
+ unsigned long __val = (val); \
asm volatile ( "mov %0,%%db" #reg : : "r" (__val) ); \
} while (0)
#define read_debugreg(reg) ({ \
--
generated by git-patchbot for /home/xen/git/xen.git#staging