Mailing List Archive

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1301591485 -3600
# Node ID 0ab435637ec0f6476fb4f90c8c74c77f809fbb3d
# Parent c8ae80a11d4772f8b1e28fb1364590532da95519
libxl: remove "reg" and "enable" fields from PCI device.

The structure of the BDF argument used with PCI passthrough related
hypercalls was taken from the structure of the PCI config_address
register (I/O port 0xCF8) which allows I/O mapped access to PCI
configuration space but these fields have no meaning in the context of
PCI passthrough configuration and hence do not need to be exposed via
libxl.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
---


diff -r c8ae80a11d47 -r 0ab435637ec0 tools/libxl/libxl.idl
--- a/tools/libxl/libxl.idl Thu Mar 31 18:06:36 2011 +0100
+++ b/tools/libxl/libxl.idl Thu Mar 31 18:11:25 2011 +0100
@@ -243,11 +243,9 @@
])

libxl_device_pci = Struct("device_pci", [
- ("reg", uint8),
("func", uint8),
("dev", uint8),
("bus", uint8),
- ("enable", bool),
("domain", unsigned_integer),
("vdevfn", unsigned_integer),
("vfunc_mask", unsigned_integer),
diff -r c8ae80a11d47 -r 0ab435637ec0 tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c Thu Mar 31 18:06:36 2011 +0100
+++ b/tools/libxl/libxl_pci.c Thu Mar 31 18:11:25 2011 +0100
@@ -41,29 +41,16 @@
#define PCI_BDF_SHORT "%02x:%02x.%01x"
#define PCI_BDF_VDEVFN "%04x:%02x:%02x.%01x@%02x"

-static unsigned int pcidev_value(libxl_device_pci *pcidev)
+static unsigned int pcidev_encode_bdf(libxl_device_pci *pcidev)
{
- union {
- unsigned int value;
- struct {
- unsigned int reserved1:2;
- unsigned int reg:6;
- unsigned int func:3;
- unsigned int dev:5;
- unsigned int bus:8;
- unsigned int reserved2:7;
- unsigned int enable:1;
- }fields;
- }u;
+ unsigned int value;

- u.value = 0;
- u.fields.reg = pcidev->reg;
- u.fields.func = pcidev->func;
- u.fields.dev = pcidev->dev;
- u.fields.bus = pcidev->bus;
- u.fields.enable = pcidev->enable;
+ value = 0;
+ value |= (pcidev->bus & 0xff) << 16;
+ value |= (pcidev->dev & 0x1f) << (8+3);
+ value |= (pcidev->func & 0x3) << (8+0);

- return u.value;
+ return value;
}

static int pcidev_init(libxl_device_pci *pcidev, unsigned int domain,
@@ -711,7 +698,7 @@
}
out:
if (!libxl_is_stubdom(ctx, domid, NULL)) {
- rc = xc_assign_device(ctx->xch, domid, pcidev_value(pcidev));
+ rc = xc_assign_device(ctx->xch, domid, pcidev_encode_bdf(pcidev));
if (rc < 0 && (hvm || errno != ENOSYS)) {
LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, rc, "xc_assign_device failed");
return ERROR_FAIL;
@@ -938,7 +925,7 @@
}

if (!libxl_is_stubdom(ctx, domid, NULL)) {
- rc = xc_deassign_device(ctx->xch, domid, pcidev_value(pcidev));
+ rc = xc_deassign_device(ctx->xch, domid, pcidev_encode_bdf(pcidev));
if (rc < 0 && (hvm || errno != ENOSYS))
LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, rc, "xc_deassign_device failed");
}
diff -r c8ae80a11d47 -r 0ab435637ec0 tools/ocaml/libs/xl/xl_stubs.c
--- a/tools/ocaml/libs/xl/xl_stubs.c Thu Mar 31 18:06:36 2011 +0100
+++ b/tools/ocaml/libs/xl/xl_stubs.c Thu Mar 31 18:11:25 2011 +0100
@@ -288,11 +288,9 @@

/* FIXME: propagate API change to ocaml */
u.value = Int_val(Field(v, 0));
- c_val->reg = u.fields.reg;
c_val->func = u.fields.func;
c_val->dev = u.fields.dev;
c_val->bus = u.fields.bus;
- c_val->enable = u.fields.enable;

c_val->domain = Int_val(Field(v, 1));
c_val->vdevfn = Int_val(Field(v, 2));

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog