Mailing List Archive

# HG changeset patch
# User Stefano Stabellini <stefano.stabellini@eu.citrix.com>
# Date 1297446788 0
# Node ID 9280f16747050815a3ab1e180408bc4d9bcd0e86
# Parent 4376c4f0196f0dc129904a0f8c54c74ae4bcdff2
libxl: do not call libxl__file_reference_unmap twice

Fix double free due to libxl__file_reference_unmap(&info->kernel) called
multiple times: first at the end of libxl__domain_build and then in
libxl_domain_build_info_destroy.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
tools/libxl/libxl_create.c | 3 ---
1 files changed, 3 deletions(-)

diff -r 4376c4f0196f -r 9280f1674705 tools/libxl/libxl_create.c
--- a/tools/libxl/libxl_create.c Fri Feb 11 17:49:13 2011 +0000
+++ b/tools/libxl/libxl_create.c Fri Feb 11 17:53:08 2011 +0000
@@ -196,9 +196,6 @@ int libxl__domain_build(libxl_ctx *ctx,
}
ret = libxl__build_post(ctx, domid, info, state, vments, localents);
out:
- libxl__file_reference_unmap(&info->kernel);
- if (!info->hvm)
- libxl__file_reference_unmap(&info->u.pv.ramdisk);

libxl__free_all(&gc);
return ret;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog