Mailing List Archive

# HG changeset patch
# User Keir Fraser <keir.fraser@citrix.com>
# Date 1271746487 -3600
# Node ID b2c56f91da8d34e4daf4cceb1fc8a70a33656ae2
# Parent fadf63ab49e736adad49116672d168c321c8e060
x86: No need to sync_local_execstate() during CPU hot-unplug.

This is done implicitly when we enter stopmachine_run() context,
because the underlying tasklet mechanism performs the sync before
running a tasklet handler.

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
---
xen/arch/x86/smpboot.c | 13 +------------
1 files changed, 1 insertion(+), 12 deletions(-)

diff -r fadf63ab49e7 -r b2c56f91da8d xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c Mon Apr 19 17:57:28 2010 +0100
+++ b/xen/arch/x86/smpboot.c Tue Apr 20 07:54:47 2010 +0100
@@ -1002,11 +1002,7 @@ void cpu_exit_clear(void)
{
int cpu = raw_smp_processor_id();

- /* Previous non-idle state should be synchronised already. */
- if (__sync_local_execstate())
- BUG();
-
- cpucount --;
+ cpucount--;
cpu_uninit();

cpu_clear(cpu, cpu_callout_map);
@@ -1298,13 +1294,6 @@ int __cpu_disable(void)
cpu_mcheck_disable();

remove_siblinginfo(cpu);
-
- /*
- * If we are running the idle vcpu, sync last non-idle vcpu's state
- * before changing cpu_online_map. If we are running non-idle vcpu,
- * we will synchronously sync the state in context_switch() later.
- */
- sync_local_execstate();

/* It's now safe to remove this processor from the online map */
cpu_clear(cpu, cpu_online_map);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog