Mailing List Archive

# HG changeset patch
# User Keir Fraser <keir.fraser@citrix.com>
# Date 1268294977 0
# Node ID d3720d9511739fc009aad2076e77e9437c175d07
# Parent 594142f8c0bbc8dcc47074f5a4a679a14df9117c
Fix 21020:3198a2e81d38

This has a pretty serious bug. ioapic_to_iommu() gets returned
drhd->iommu. However, drhd->iommu isn't allocated until part of
iommu_setup(), which is called after enable_x2apic(). Has this ever
worked?

Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
xen/drivers/passthrough/vtd/intremap.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 594142f8c0bb -r d3720d951173 xen/drivers/passthrough/vtd/intremap.c
--- a/xen/drivers/passthrough/vtd/intremap.c Thu Mar 11 08:08:32 2010 +0000
+++ b/xen/drivers/passthrough/vtd/intremap.c Thu Mar 11 08:09:37 2010 +0000
@@ -134,7 +134,7 @@ int iommu_supports_eim(void)

/* We MUST have a DRHD unit for each IOAPIC. */
for ( apic = 0; apic < nr_ioapics; apic++ )
- if ( !ioapic_to_iommu(IO_APIC_ID(apic)) )
+ if ( !ioapic_to_drhd(IO_APIC_ID(apic)) )
return 0;

if ( list_empty(&acpi_drhd_units) )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog