Mailing List Archive

# HG changeset patch
# User kaf24@firebug.cl.cam.ac.uk
# Node ID faf5c318f9b06ba90650436d5842a8009b9ab8fe
# Parent f8af1ac29ecb9b99176d54e937928db768e7ee37
Fix the zombie domain when destroying 2.6 linux vmx guest.
The zombie domain is caused by unreleased shadow page
because of lack of put_shadow_ref.
When unshadow a L1 page, set l2e to zero and put ref.

Signed-off-by: <xiaofeng.ling@intel.com>

diff -r f8af1ac29ecb -r faf5c318f9b0 xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c Mon Nov 21 22:19:26 2005
+++ b/xen/arch/x86/shadow.c Tue Nov 22 06:08:57 2005
@@ -1536,12 +1536,13 @@
perfc_incr_histo(l1_entries_checked, max_shadow - min_shadow + 1, PT_UPDATES);
if ( d->arch.ops->guest_paging_levels >= PAGING_L3 &&
unshadow_l1 ) {
- pgentry_64_t l2e = {0};
+ pgentry_64_t l2e;

__shadow_get_l2e(entry->v, entry->va, &l2e);

if ( entry_get_flags(l2e) & _PAGE_PRESENT ) {
- entry_remove_flags(l2e, _PAGE_PRESENT);
+ put_shadow_ref(entry_get_pfn(l2e));
+ l2e = entry_empty();
__shadow_set_l2e(entry->v, entry->va, &l2e);

if (entry->v == current)
diff -r f8af1ac29ecb -r faf5c318f9b0 xen/arch/x86/shadow32.c
--- a/xen/arch/x86/shadow32.c Mon Nov 21 22:19:26 2005
+++ b/xen/arch/x86/shadow32.c Tue Nov 22 06:08:57 2005
@@ -2426,7 +2426,8 @@

__shadow_get_l2e(entry->v, entry->va, &l2e);
if (l2e_get_flags(l2e) & _PAGE_PRESENT) {
- l2e_remove_flags(l2e, _PAGE_PRESENT);
+ put_shadow_ref(l2e_get_pfn(l2e));
+ l2e = l2e_empty();
__shadow_set_l2e(entry->v, entry->va, l2e);

if (entry->v == current)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog