Mailing List Archive

Cleanup after merge
ChangeSet 1.1270, 2005/04/05 09:49:46+01:00, mafetter@fleming.research

Cleanup after merge

Signed-off-by: michael.fetterman@cl.cam.ac.uk



arch/x86/mm.c | 2 +-
arch/x86/shadow.c | 21 ++++++---------------
include/asm-x86/mm.h | 12 +++++-------
3 files changed, 12 insertions(+), 23 deletions(-)


diff -Nru a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c 2005-04-05 12:22:13 -04:00
+++ b/xen/arch/x86/mm.c 2005-04-05 12:22:13 -04:00
@@ -2683,7 +2683,7 @@
int which;
u32 l2_idx;

- if ( unlikely(shadow_mode_enabled(ed->domain)) )
+ if ( unlikely(shadow_mode_enabled(d)) )
return 0;

/*
diff -Nru a/xen/arch/x86/shadow.c b/xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c 2005-04-05 12:22:13 -04:00
+++ b/xen/arch/x86/shadow.c 2005-04-05 12:22:13 -04:00
@@ -583,6 +583,11 @@
{
}

+int _shadow_mode_enabled(struct domain *d)
+{
+ return shadow_mode_enabled(d);
+}
+
static void alloc_monitor_pagetable(struct exec_domain *ed)
{
unsigned long mmfn;
@@ -2623,21 +2628,7 @@
// thus potentially out-of-sync) guest page.
//
if ( VM_ASSIST(d, VMASST_TYPE_writable_pagetables) )
- {
- int cpu = current->processor;
-
- for ( i = 0; i < ARRAY_SIZE(ptwr_info->ptinfo); i++)
- {
- if ( ptwr_info[cpu].ptinfo[i].l1va &&
- ((v2m(ptwr_info[cpu].ptinfo[i].pl1e) >> PAGE_SHIFT) == gmfn) )
- {
- unsigned long old = gmfn;
- gmfn = (v2m(ptwr_info[cpu].ptinfo[i].page) >> PAGE_SHIFT);
- printk("hit1 ptwr_info[%d].ptinfo[%d].l1va, mfn=0x%08x, snapshot=0x%08x\n",
- cpu, i, old, gmfn);
- }
- }
- }
+ BUG();

if ( page_out_of_sync(pfn_to_page(gmfn)) )
{
diff -Nru a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h
--- a/xen/include/asm-x86/mm.h 2005-04-05 12:22:13 -04:00
+++ b/xen/include/asm-x86/mm.h 2005-04-05 12:22:13 -04:00
@@ -4,8 +4,8 @@

#include <xen/config.h>
#include <xen/list.h>
-#include <xen/sched.h>
#include <asm/io.h>
+#include <asm/uaccess.h>

/*
* Per-page-frame information.
@@ -150,6 +150,7 @@
extern int shadow_remove_all_write_access(
struct domain *d, unsigned long gpfn, unsigned long gmfn);
extern u32 shadow_remove_all_access( struct domain *d, unsigned long gmfn);
+extern int _shadow_mode_enabled(struct domain *d);

static inline void put_page(struct pfn_info *page)
{
@@ -181,12 +182,9 @@
unlikely((nx & PGC_count_mask) == 0) || /* Count overflow? */
unlikely(d != _domain) ) /* Wrong owner? */
{
- if ( !domain->arch.shadow_mode )
- DPRINTK("Error pfn %p: rd=%p(%d), od=%p(%d), caf=%08x, "
- "taf=%08x\n",
- page_to_pfn(page), domain, (domain ? domain->id : -1),
- page_get_owner(page),
- (page_get_owner(page) ? page_get_owner(page)->id : -1),
+ if ( !_shadow_mode_enabled(domain) )
+ DPRINTK("Error pfn %p: rd=%p, od=%p, caf=%08x, taf=%08x\n",
+ page_to_pfn(page), domain, unpickle_domptr(d),
x, page->u.inuse.type_info);
return 0;
}

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog
cleanup after merge [ In reply to ]
ChangeSet 1.1289, 2005/04/12 11:16:00+01:00, mafetter@fleming.research

cleanup after merge



linux-2.6.11-xen-sparse/arch/xen/configs/xen0_defconfig_x86_32 | 1
linux-2.6.11-xen-sparse/arch/xen/configs/xenU_defconfig_x86_32 | 2 -
xen/include/asm-x86/shadow.h | 11 ----------
3 files changed, 3 insertions(+), 11 deletions(-)


diff -Nru a/linux-2.6.11-xen-sparse/arch/xen/configs/xen0_defconfig_x86_32 b/linux-2.6.11-xen-sparse/arch/xen/configs/xen0_defconfig_x86_32
--- a/linux-2.6.11-xen-sparse/arch/xen/configs/xen0_defconfig_x86_32 2005-04-13 19:03:21 -04:00
+++ b/linux-2.6.11-xen-sparse/arch/xen/configs/xen0_defconfig_x86_32 2005-04-13 19:03:21 -04:00
@@ -20,6 +20,7 @@
CONFIG_XEN_NETDEV_FRONTEND=y
# CONFIG_XEN_NETDEV_FRONTEND_PIPELINED_TRANSMITTER is not set
# CONFIG_XEN_BLKDEV_TAP is not set
+# CONFIG_XEN_SHADOW_MODE is not set
CONFIG_XEN_SCRUB_PAGES=y
CONFIG_XEN_X86=y
# CONFIG_XEN_X86_64 is not set
diff -Nru a/linux-2.6.11-xen-sparse/arch/xen/configs/xenU_defconfig_x86_32 b/linux-2.6.11-xen-sparse/arch/xen/configs/xenU_defconfig_x86_32
--- a/linux-2.6.11-xen-sparse/arch/xen/configs/xenU_defconfig_x86_32 2005-04-13 19:03:21 -04:00
+++ b/linux-2.6.11-xen-sparse/arch/xen/configs/xenU_defconfig_x86_32 2005-04-13 19:03:21 -04:00
@@ -17,7 +17,7 @@
CONFIG_XEN_NETDEV_FRONTEND=y
# CONFIG_XEN_NETDEV_FRONTEND_PIPELINED_TRANSMITTER is not set
# CONFIG_XEN_BLKDEV_TAP is not set
-CONFIG_XEN_SHADOW_MODE=y
+# CONFIG_XEN_SHADOW_MODE is not set
CONFIG_XEN_SCRUB_PAGES=y
CONFIG_XEN_X86=y
# CONFIG_XEN_X86_64 is not set
diff -Nru a/xen/include/asm-x86/shadow.h b/xen/include/asm-x86/shadow.h
--- a/xen/include/asm-x86/shadow.h 2005-04-13 19:03:21 -04:00
+++ b/xen/include/asm-x86/shadow.h 2005-04-13 19:03:21 -04:00
@@ -398,28 +398,19 @@
page->count_info, page->u.inuse.type_info);
}

+/* XXX Needs more thought. Neither pretty nor fast: a place holder. */
static inline void shadow_sync_and_drop_references(
struct domain *d, struct pfn_info *page)
{
if ( likely(!shadow_mode_enabled(d)) )
return;

- /* XXX Needs more thought. Neither pretty nor fast: a place holder. */
shadow_lock(d);

if ( page_out_of_sync(page) )
__shadow_sync_mfn(d, page_to_pfn(page));

shadow_remove_all_access(d, page_to_pfn(page));
-
- if ( page->count_info != 1 )
- {
- printk("free_dom_mem in shadow mode didn't release page "
- "mfn=%p c=%p\n", page_to_pfn(page), page->count_info);
- shadow_unlock(d);
- audit_domain(d);
- BUG();
- }

shadow_unlock(d);
}

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog