Mailing List Archive: Committed stuff

Committed stuff

Jul 11, 2003, 6:50 AM

Post #1 of 5 (224 views)

Speaking of committed stuff, now that I have finally managed to gain CVS
access, I have committed the following changes (if someone could put
them on the test server, that would be great):

- OutputPage.php: The apostrophe-stuff. See
http://test.wikipedia.org/wiki/Apostrophe_Test_page

- SearchEngine.php: "Go" button redirects to the article if one found
(rather than displaying it under the "search" URL).

Please everyone test :-)

Timwi

Re: Committed stuff [ In reply to ]

erik_moeller at gmx

Jul 11, 2003, 8:49 AM

Post #2 of 5 (229 views)

Permalink

Timwi-

> - SearchEngine.php: "Go" button redirects to the article if one found
> (rather than displaying it under the "search" URL).

This doesn't work if mod_rewrite is not set up -- not good, as many of our
installations don't use it.

You also did not implement it for the last stage (title match). And it
breaks the Go button for titles which are not in the article namespace
(namespace is not prefixed).

Regards,

Erik

Re: Committed stuff [ In reply to ]

timwi at gmx

Jul 11, 2003, 9:46 AM

Post #3 of 5 (224 views)

Permalink

Erik Moeller wrote:

>>- SearchEngine.php: "Go" button redirects to the article if one found
>> (rather than displaying it under the "search" URL).
>
> This doesn't work if mod_rewrite is not set up -- not good, as many of our
> installations don't use it.
> You also did not implement it for the last stage (title match).

Thanks. Fixed.

> And it
> breaks the Go button for titles which are not in the article namespace
> (namespace is not prefixed).

The Go button never returns pages that are not in the article namespace.

Regardless, I've fixed that too.

Anything else?

Greetings,
Timwi

Re: Re: Committed stuff [ In reply to ]

erik_moeller at gmx

Jul 11, 2003, 12:10 PM

Post #4 of 5 (222 views)

Permalink

Timwi-
> The Go button never returns pages that are not in the article namespace.

That's simply not true.

Regards,

Erik

Re: Committed stuff [ In reply to ]

timwi at gmx

Jul 11, 2003, 12:54 PM

Post #5 of 5 (225 views)

Permalink

Erik Moeller wrote:

> Timwi-
>
>>The Go button never returns pages that are not in the article namespace.
> That's simply not true.

You appear to be right. I could have sworn I tried that several times in
the past and it never worked.

Thanks for your enlightenment,
Timwi