Mailing List Archive: SpecialContributions.php

SpecialContributions.php

May 17, 2003, 6:29 AM

Post #1 of 4 (173 views)

I found this in SpecialContributions.php (about line 72):

if ( 0 == $nCur && 0 == $nOld && 0 == $rcrows ) {
$wgOut->addHTML( "\n" . wfMsg( "nocontribs" ) . "\n" );
return;
}

What I'm missing is the $rcrows variable initialisation. Hopefully php init
it with 0, but I'm not sure.

Possibly Lee or Brion have an idea :)

--
Smurf

smurf@AdamAnt.mud.de
------------------------- Anthill inside! ---------------------------

Re: SpecialContributions.php [ In reply to ]

mrwojo at earthlink

May 17, 2003, 7:24 AM

Post #2 of 4 (173 views)

Permalink

"Thomas Corell" said:
> I found this in SpecialContributions.php (about line 72):
>
> if ( 0 == $nCur && 0 == $nOld && 0 == $rcrows ) {
> $wgOut->addHTML( "\n" . wfMsg( "nocontribs" ) . "\n" );
> return;
> }
>
> What I'm missing is the $rcrows variable initialisation. Hopefully
> php init it with 0, but I'm not sure.

I don't know where or if $rcrows is initialized, but uninitialized variables
in PHP 4 are set to NULL which == 0.

--
Mark

Re: SpecialContributions.php [ In reply to ]

T.Corell at t-online

May 17, 2003, 7:36 AM

Post #3 of 4 (172 views)

Permalink

Mark Wojtowicz wrote:
> "Thomas Corell" said:
>
> I don't know where or if $rcrows is initialized, but uninitialized variables
> in PHP 4 are set to NULL which == 0.

Fine, I hoped it.
I see I did not explain it clearly: 'grep -i rcrows' in the CVS only showed
the mentioned line. I think the comparison is useless, but I'm not as fit
as e.g. Lee with the code.

--
Smurf

smurf@AdamAnt.mud.de
------------------------- Anthill inside! ---------------------------

Re: SpecialContributions.php [ In reply to ]

timstarling at hotmail

May 18, 2003, 7:09 AM

Post #4 of 4 (168 views)

Permalink

Thomas Corell wrote:
>
> I found this in SpecialContributions.php (about line 72):
>
>
> if ( 0 == $nCur && 0 == $nOld && 0 == $rcrows ) {
> $wgOut->addHTML( "\n" . wfMsg( "nocontribs" ) . "\n" );
> return;
> }
>
> What I'm missing is the $rcrows variable initialisation. Hopefully php
> init it with 0, but I'm not sure.
>
> Possibly Lee or Brion have an idea :)
>

Looks like a chunk of code has been deleted. There's a comment which says:

# Sorting slowness on cur and especially old
# forces us to check RC table first

But the code never touches RC.

-- Tim Starling