Mailing List Archive

Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406056 )

Change subject: Type hint against IDatabase instead of Database
......................................................................

Type hint against IDatabase instead of Database

The interface is smaller, and all that's needed here.

This patch also removes an obsolete documentation that is 100%
identical to the method header.

Change-Id: Ia666dec4dfea7089183d4adb5c42bf6ffbf0b4f6
---
M includes/BaseTemplateToolboxHookHandler.php
M includes/ItemNotabilityFilter.php
2 files changed, 3 insertions(+), 8 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder refs/changes/56/406056/1

diff --git a/includes/BaseTemplateToolboxHookHandler.php b/includes/BaseTemplateToolboxHookHandler.php
index 986ff2c..afbc19d 100644
--- a/includes/BaseTemplateToolboxHookHandler.php
+++ b/includes/BaseTemplateToolboxHookHandler.php
@@ -49,11 +49,6 @@
);
}

- /**
- * @param EntityIdParser $entityIdParser
- * @param RepoLinker $repoLinker
- * @param EntityLookup $entityLookup
- */
public function __construct(
EntityIdParser $entityIdParser,
RepoLinker $repoLinker,
diff --git a/includes/ItemNotabilityFilter.php b/includes/ItemNotabilityFilter.php
index 3974a62..d41d2d3 100644
--- a/includes/ItemNotabilityFilter.php
+++ b/includes/ItemNotabilityFilter.php
@@ -5,7 +5,7 @@
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\Lib\Store\EntityNamespaceLookup;
use Wikibase\Lib\Store\SiteLinkLookup;
-use Wikimedia\Rdbms\Database;
+use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\ResultWrapper;
use Wikimedia\Rdbms\SessionConsistentConnectionManager;

@@ -120,12 +120,12 @@
}

/**
- * @param Database $dbr
+ * @param IDatabase $dbr
* @param ItemId[] $itemIds
*
* @return ResultWrapper
*/
- private function selectPagePropsPage( Database $dbr, array $itemIds ) {
+ private function selectPagePropsPage( IDatabase $dbr, array $itemIds ) {
$entityNamespace = $this->entityNamespaceLookup->getEntityNamespace( 'item' );

if ( !is_int( $entityNamespace ) ) {

--
To view, visit https://gerrit.wikimedia.org/r/406056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia666dec4dfea7089183d4adb5c42bf6ffbf0b4f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits