Mailing List Archive

Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405921 )

Change subject: Fix: Reading Lists: Articles without lead image should show placeholders
......................................................................

Fix: Reading Lists: Articles without lead image should show placeholders

Removed additional checks which were breaking the logic to show placeholders.

Bug: T185543
Change-Id: I591acce13bc316d06ae7dd66b4b627fe20a38150
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListHeaderView.java
M app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
2 files changed, 6 insertions(+), 10 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/21/405921/1

diff --git a/app/src/main/java/org/wikipedia/readinglist/ReadingListHeaderView.java b/app/src/main/java/org/wikipedia/readinglist/ReadingListHeaderView.java
index 92c948d..ebd1500 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListHeaderView.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListHeaderView.java
@@ -104,11 +104,9 @@
clearThumbnails();
List<String> thumbUrls = new ArrayList<>();
for (ReadingListPage page : readingList.pages()) {
- if (!TextUtils.isEmpty(page.thumbUrl())) {
- thumbUrls.add(page.thumbUrl());
- if (thumbUrls.size() > imageViews.size()) {
- break;
- }
+ thumbUrls.add(page.thumbUrl());
+ if (thumbUrls.size() > imageViews.size()) {
+ break;
}
}
for (int i = 0; i < thumbUrls.size() && i < imageViews.size(); ++i) {
diff --git a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
index 1cd5cf6..d7e253f 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
@@ -183,11 +183,9 @@
clearThumbnails();
List<String> thumbUrls = new ArrayList<>();
for (ReadingListPage page : readingList.pages()) {
- if (!TextUtils.isEmpty(page.thumbUrl())) {
- thumbUrls.add(page.thumbUrl());
- if (thumbUrls.size() > imageViews.size()) {
- break;
- }
+ thumbUrls.add(page.thumbUrl());
+ if (thumbUrls.size() > imageViews.size()) {
+ break;
}
}
for (int i = 0; i < thumbUrls.size() && i < imageViews.size(); ++i) {

--
To view, visit https://gerrit.wikimedia.org/r/405921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I591acce13bc316d06ae7dd66b4b627fe20a38150
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Sharvaniharan <sharan@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits