Mailing List Archive

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405893 )

Change subject: Expand ReferenceContextTest::testGetSnakGroup
......................................................................


Expand ReferenceContextTest::testGetSnakGroup

This expands the test for ReferenceContext::getSnakGroup() to make sure
that the function doesn’t look at qualifiers of the statement, or any
any part of completely unrelated other statements. Previously, we only
checked that the function didn’t look at other references.

Bug: T168240
Change-Id: Idc7b6d44e10c4b0b9471f915474cd4d136daa4dc
---
M tests/phpunit/Context/ReferenceContextTest.php
1 file changed, 16 insertions(+), 5 deletions(-)

Approvals:
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/tests/phpunit/Context/ReferenceContextTest.php b/tests/phpunit/Context/ReferenceContextTest.php
index 5d9ec29..2d25500 100644
--- a/tests/phpunit/Context/ReferenceContextTest.php
+++ b/tests/phpunit/Context/ReferenceContextTest.php
@@ -6,6 +6,8 @@
use Wikibase\DataModel\Reference;
use Wikibase\DataModel\ReferenceList;
use Wikibase\DataModel\Snak\PropertyNoValueSnak;
+use Wikibase\DataModel\Snak\PropertySomeValueSnak;
+use Wikibase\DataModel\Snak\SnakList;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\Repo\Tests\NewItem;
use Wikibase\Repo\Tests\NewStatement;
@@ -85,17 +87,26 @@
public function testGetSnakGroup() {
$referenceSnak1 = NewStatement::noValueFor( 'P100' )->build()->getMainSnak();
$referenceSnak2 = NewStatement::someValueFor( 'P200' )->build()->getMainSnak();
+ $referenceSnak3 = NewStatement::noValueFor( 'P300' )->build()->getMainSnak();
+ $referenceSnak4 = NewStatement::someValueFor( 'P400' )->build()->getMainSnak();
$reference1 = new Reference( [ $referenceSnak1, $referenceSnak2 ] );
- $reference2 = new Reference( [ new PropertyNoValueSnak( new PropertyId( 'P300' ) ) ] );
- $statement = new Statement(
+ $reference2 = new Reference( [ $referenceSnak3 ] );
+ $reference3 = new Reference( [ $referenceSnak4 ] );
+ $statement1 = new Statement(
new PropertyNoValueSnak( new PropertyId( 'P1' ) ),
- null,
+ /* qualifiers = */ new SnakList( [ $referenceSnak3 ] ),
new ReferenceList( [ $reference1, $reference2 ] )
);
+ $statement2 = new Statement(
+ new PropertySomeValueSnak( new PropertyId( 'P2' ) ),
+ null,
+ new ReferenceList( [ $reference2, $reference3 ] )
+ );
$entity = NewItem::withId( 'Q1' )
- ->andStatement( $statement )
+ ->andStatement( $statement1 )
+ ->andStatement( $statement2 )
->build();
- $context = new ReferenceContext( $entity, $statement, $reference1, $referenceSnak1 );
+ $context = new ReferenceContext( $entity, $statement1, $reference1, $referenceSnak1 );

$snakGroup = $context->getSnakGroup();


--
To view, visit https://gerrit.wikimedia.org/r/405893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc7b6d44e10c4b0b9471f915474cd4d136daa4dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeister@wikimedia.de>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits