Mailing List Archive

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405874 )

Change subject: Remove not needed …->withSomeGuid() calls from tests
......................................................................


Remove not needed …->withSomeGuid() calls from tests

These calls have been introduced with I0fced66. They do, in fact, not
make any difference. At least for now. This might change with future
patches (e.g. "upcoming changes to ValueCountCheckerHelper" have been
mentioned). I want to leave this here as a reminder to recheck when this
happened.

Bug: T168240
Change-Id: Ie5a7652d609721cf91a5619cc89b35101601dd51
---
M tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
2 files changed, 12 insertions(+), 12 deletions(-)

Approvals:
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, but someone else must approve



diff --git a/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php b/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
index cfdd52d..683b37d 100644
--- a/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
@@ -44,7 +44,7 @@
}

public function testMultiValueConstraint_One() {
- $statement = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
+ $statement = NewStatement::noValueFor( 'P1' )->build();
$item = NewItem::withStatement( $statement )->build();
$context = new MainSnakContext( $item, $statement );

@@ -54,8 +54,8 @@
}

public function testMultiValueConstraint_Two() {
- $statement1 = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
- $statement2 = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
+ $statement1 = NewStatement::noValueFor( 'P1' )->build();
+ $statement2 = NewStatement::noValueFor( 'P1' )->build();
$item = NewItem::withStatement( $statement1 )->andStatement( $statement2 )->build();
$context = new MainSnakContext( $item, $statement1 );

@@ -65,10 +65,10 @@
}

public function testMultiValueConstraint_TwoButOneDeprecated() {
- $statement1 = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
+ $statement1 = NewStatement::noValueFor( 'P1' )->build();
$statement2 = NewStatement::noValueFor( 'P1' )
->withDeprecatedRank()
- ->withSomeGuid()->build();
+ ->build();
$item = NewItem::withStatement( $statement1 )->andStatement( $statement2 )->build();
$context = new MainSnakContext( $item, $statement1 );

@@ -110,7 +110,7 @@
public function testSingleValueConstraintDeprecatedStatement() {
$statement = NewStatement::noValueFor( 'P1' )
->withDeprecatedRank()
- ->withSomeGuid()->build();
+ ->build();
$entity = NewItem::withId( 'Q1' )
->build();
$context = new MainSnakContext( $entity, $statement );
diff --git a/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php b/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
index 7d4404f..6afd45d 100644
--- a/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
@@ -44,7 +44,7 @@
}

public function testSingleValueConstraint_One() {
- $statement = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
+ $statement = NewStatement::noValueFor( 'P1' )->build();
$item = NewItem::withStatement( $statement )->build();
$context = new MainSnakContext( $item, $statement );

@@ -54,8 +54,8 @@
}

public function testSingleValueConstraint_Two() {
- $statement1 = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
- $statement2 = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
+ $statement1 = NewStatement::noValueFor( 'P1' )->build();
+ $statement2 = NewStatement::noValueFor( 'P1' )->build();
$item = NewItem::withStatement( $statement1 )->andStatement( $statement2 )->build();
$context = new MainSnakContext( $item, $statement1 );

@@ -65,10 +65,10 @@
}

public function testSingleValueConstraint_TwoButOneDeprecated() {
- $statement1 = NewStatement::noValueFor( 'P1' )->withSomeGuid()->build();
+ $statement1 = NewStatement::noValueFor( 'P1' )->build();
$statement2 = NewStatement::noValueFor( 'P1' )
->withDeprecatedRank()
- ->withSomeGuid()->build();
+ ->build();
$item = NewItem::withStatement( $statement1 )->andStatement( $statement2 )->build();
$context = new MainSnakContext( $item, $statement1 );

@@ -110,7 +110,7 @@
public function testSingleValueConstraintDeprecatedStatement() {
$statement = NewStatement::noValueFor( 'P1' )
->withDeprecatedRank()
- ->withSomeGuid()->build();
+ ->build();
$entity = NewItem::withId( 'Q1' )
->build();
$context = new MainSnakContext( $entity, $statement );

--
To view, visit https://gerrit.wikimedia.org/r/405874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5a7652d609721cf91a5619cc89b35101601dd51
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeister@wikimedia.de>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits