Mailing List Archive

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405351 )

Change subject: Hygiene: fix jsdoc in extractLeadIntroduction
......................................................................


Hygiene: fix jsdoc in extractLeadIntroduction

Change-Id: I1268821bfcf65470202ca76ff21143236772f63a
---
M lib/transformations/extractLeadIntroduction.js
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved



diff --git a/lib/transformations/extractLeadIntroduction.js b/lib/transformations/extractLeadIntroduction.js
index 7661b2c..0157f73 100644
--- a/lib/transformations/extractLeadIntroduction.js
+++ b/lib/transformations/extractLeadIntroduction.js
@@ -3,22 +3,22 @@
const NodeType = require('../nodeType');
const _ = require('underscore');

-/*
+/**
* Check whether a node has any content.
- * @param {!DOMElement} node
- * @return {!Boolean} whether the node is empty after all whitespace is stripped.
+ * @param {!Element} node
+ * @return {!boolean} whether the node is empty after all whitespace is stripped.
*/
function isEmpty(node) {
return node.textContent.trim().length === 0;
}

-/*
+/**
* Extracts the first non-empty paragraph from an article and any
* nodes that follow it that are not themselves paragraphs.
* @param {!Document} doc representing article
- * @param {Boolean} removeNodes when set the lead introduction will
+ * @param {boolean} removeNodes when set the lead introduction will
* be removed from the input DOM tree.
- * @return {String} representing article introduction
+ * @return {string} representing article introduction
*/
function extractLeadIntroduction(doc, removeNodes) {
let p = '';

--
To view, visit https://gerrit.wikimedia.org/r/405351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1268821bfcf65470202ca76ff21143236772f63a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzmann@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfloyd@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrobson@wikimedia.org>
Gerrit-Reviewer: Mholloway <mholloway@wikimedia.org>
Gerrit-Reviewer: Mhurd <mhurd@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppchelko@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits