Mailing List Archive: *.body VMOD arguments

Hi,

we have two VIPS related to body access:

* https://github.com/varnishcache/varnish-cache/wiki/VIP-30:-bereq.body_filters

is about filters for the request body (which I am probably going to get to)

* https://github.com/varnishcache/varnish-cache/wiki/VIP14:-*.body-access

is about a new way to create a synth body

But I can not remember if we ever talked about *.body as VMOD function/method
arguments? If we did, please remind me.

If not, I would suggest that we add those as a pointer to the respective
objcore. Because VCL_BODY currently is typedef'd as const void *, we would
need to change that and rewrite the existing VCC code for "VCL_BODY += ..." and
"unset VCL_BODY", but I see no fundamental problem with that.

Any ideas/comments?

Thank you, Nils
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

--------
Nils Goroll writes:

> But I can not remember if we ever talked about *.body as VMOD function/method
> arguments? If we did, please remind me.
>
> If not, I would suggest that we add those as a pointer to the respective
> objcore. Because VCL_BODY currently is typedef'd as const void *, we would
> need to change that and rewrite the existing VCC code for "VCL_BODY += ..." and
> "unset VCL_BODY", but I see no fundamental problem with that.

We already have a BODY type ?

const struct type BODY[1] = {{
.magic = TYPE_MAGIC,
.name = "BODY",
.noindent = 1,
}};

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev