Mailing List Archive

#1759: VMOD abi check is always lenient
#1759: VMOD abi check is always lenient
----------------------+-------------------
Reporter: lkarsten | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Keywords:
----------------------+-------------------
In 4.0, the VMOD version check is currently always a check against the
VRT_(MAJOR|MINOR)_VERSION fields.

If I write a VMOD that uses internal structures (like
ctx->bo->synth_body), and Martin goes off and add something further up in
to struct busyobj (or struct http_conn, to pick something "completely at
random"), the VMOD compiled for the old version goes sideways when loaded
into the new version.

There is no way for the VMOD writer to signal it, and there is no error
indication for the sysadmin.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1759>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1759: VMOD abi check is always lenient [ In reply to ]
#1759: VMOD abi check is always lenient
----------------------+-----------------------
Reporter: lkarsten | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------
Changes (by lkarsten):

* owner: => lkarsten


Comment:

Discussed at bugwash. Suggestion is to add a "VRT | full" flag to
vmod.vcc, so the vmod writer can decide. Write a patch.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1759#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1759: VMOD abi check is always lenient [ In reply to ]
#1759: VMOD abi check is always lenient
----------------------+-----------------------
Reporter: lkarsten | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by lkarsten):

Discussed during VDD15Q3. We'll have a look at this after 4.1 is out. The
vrt|full stuff is a partial fix/hack, and we should do this right instead.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1759#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs