Mailing List Archive

#1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu
#1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu
--------------------------------------------+--------------------
Reporter: fleish | Type: defect
Status: new | Priority: normal
Milestone: | Component: build
Version: unknown | Severity: normal
Keywords: init init.d reload exit return |
--------------------------------------------+--------------------
This is similar to the issue reported in ticket #981, but continues on
despite the fix. Despite the reload command "/usr/share/varnish/reload-vcl
-q" returning 1, the closing "exit 0" in the script makes it so checking
the exit status of "/etc/init.d/varnish reload" is always 0 even when the
reload fails due to a syntax error for example. As a workaround, I've
removed the closing "exit 0" out of the script, but there might be a
better solution. I am running varnishd (varnish-3.0.7 revision f544cd8)

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1756>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu [ In reply to ]
#1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu
--------------------------------------------+-----------------------
Reporter: fleish | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: build | Version: unknown
Severity: normal | Resolution:
Keywords: init init.d reload exit return |
--------------------------------------------+-----------------------
Changes (by lkarsten):

* owner: => lkarsten


--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1756#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu [ In reply to ]
#1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu
--------------------------------------------+-----------------------
Reporter: fleish | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: build | Version: unknown
Severity: normal | Resolution:
Keywords: init init.d reload exit return |
--------------------------------------------+-----------------------

Comment (by lkarsten):

Thanks for reporting this.

Scripts for Varnish 4.1 does now return an error code on a failing reload,
and will write the error description to stdout/stderr.

Varnish 3 is end of life and will not get any updates.

Leaving this open until we figure out if we should apply this to 4.0 as
well.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1756#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu [ In reply to ]
#1756: /etc/init.d/varnish reload always returns 0 on debian/ubuntu
--------------------------------------------+-----------------------
Reporter: fleish | Owner: lkarsten
Type: defect | Status: closed
Priority: normal | Milestone:
Component: build | Version: unknown
Severity: normal | Resolution: fixed
Keywords: init init.d reload exit return |
--------------------------------------------+-----------------------
Changes (by lkarsten):

* status: new => closed
* resolution: => fixed


Comment:

Added to 4.0 today. New packages will be available after the next 4.0
release.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1756#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs