Mailing List Archive

#1704: fetch_failed not incremented
#1704: fetch_failed not incremented
----------------------+-------------------
Reporter: fgsch | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Keywords:
----------------------+-------------------
fetch_failed description says "Fetch failed (all causes)" but the counter
is not incremented for connect_timeout, first_byte_timeout or
between_bytes_timeout timeouts.

For connect_timeout timeout, backend_fail is increased though.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1704>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1704: fetch_failed not incremented [ In reply to ]
#1704: fetch_failed not incremented
----------------------+--------------------
Reporter: fgsch | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------

Comment (by phk):

So what do we actually mean by "failed" these days ?

I think the code currently implements "failed is when vcl_backend_error{}
is not called"

That seems useful to know at some level, but I'm not sure if this argues
for having two counters (fail w/error and fail wo/error), or just changing
the description of the one counter (fail wo/error)

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1704#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1704: fetch_failed not incremented [ In reply to ]
#1704: fetch_failed not incremented
----------------------+--------------------
Reporter: fgsch | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------

Comment (by fgsch):

I guess there are two issues here:

1. the description incorrectly implying that the counter should be
incremented

2. the fact the any errors other than connect_timeout are not be logged

We probably need to address both in one way or another.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1704#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1704: fetch_failed not incremented [ In reply to ]
#1704: fetch_failed not incremented
----------------------+-----------------------
Reporter: fgsch | Owner: fgsch
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------
Changes (by fgsch):

* status: new => assigned
* owner: => fgsch


--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1704#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs