Mailing List Archive

#1635: Completed bans keep accumulating
#1635: Completed bans keep accumulating
--------------------+----------------------
Reporter: Sesse | Type: defect
Status: new | Priority: normal
Milestone: | Component: varnishd
Version: trunk | Severity: normal
Keywords: lurker |
--------------------+----------------------
Hi,

I have a site where almost every backend response (vcl_backend_response)
produces a new ban, of the form:

ban ( "obj.http.x-analysis == 1 && obj.http.x-rglm != " +
beresp.http.x-rglm );

Pretty soon, these bans go into completed state. However, for some reason
the ban lurker doesn't manage to delete them, even though there are no
req.* bans. This seems to go on and on until I have hundreds of thousands
of bans, and BAN_Insert and ban_lurker both take significant amounts of
CPU time. Making the ban lurker wake up more often does not seem to help
anything; the ban count still goes up and never seems to go down (at all).

If I stop the backend entirely, so no requests ever go through, it seems
to actually reduce the count after a while. Start it again, and the count
increases. It's 100% reproducible for me.

Relevant parts of varnishstat -1:

MAIN.bans 507 . Count of bans
MAIN.bans_completed 505 . Number of bans marked
'completed'
MAIN.bans_obj 507 . Number of bans using
obj.*
MAIN.bans_req 0 . Number of bans using
req.*
MAIN.bans_added 25714 0.18 Bans added
MAIN.bans_deleted 25207 0.18 Bans deleted
MAIN.bans_tested 19528 0.14 Bans tested against
objects (lookup)
MAIN.bans_obj_killed 8168 0.06 Objects killed by bans
(lookup)
MAIN.bans_lurker_tested 20704629 147.19 Bans tested against
objects (lurker)
MAIN.bans_tests_tested 67431 0.48 Ban tests tested against
objects (lookup)
MAIN.bans_lurker_tests_tested 20721896 147.31 Ban tests tested
against objects (lurker)
MAIN.bans_lurker_obj_killed 13909 0.10 Objects killed by
bans (lurker)
MAIN.bans_dups 15323 0.11 Bans superseded by
other bans
MAIN.bans_lurker_contention 0 0.00 Lurker gave way
for lookup
MAIN.bans_persisted_bytes 1619932 . Bytes used by the
persisted ban lists
MAIN.bans_persisted_fragmentation 1613241 . Extra bytes in
persisted ban lists due to
fragmentation

Relevant parts of my VCL:

http://git.sesse.net/?p=remoteglot;a=blob;f=default.vcl;h=38631cb4f1d3c6f399dd4fb1378dec993339aa32;hb=HEAD

This is Varnish from git, 7746e30e2c53cf55f0f2525bb3f49c9ee83e9611.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------
Description changed by lkarsten:

Old description:

> Hi,
>
> I have a site where almost every backend response (vcl_backend_response)
> produces a new ban, of the form:
>
> ban ( "obj.http.x-analysis == 1 && obj.http.x-rglm != " +
> beresp.http.x-rglm );
>
> Pretty soon, these bans go into completed state. However, for some reason
> the ban lurker doesn't manage to delete them, even though there are no
> req.* bans. This seems to go on and on until I have hundreds of thousands
> of bans, and BAN_Insert and ban_lurker both take significant amounts of
> CPU time. Making the ban lurker wake up more often does not seem to help
> anything; the ban count still goes up and never seems to go down (at
> all).
>
> If I stop the backend entirely, so no requests ever go through, it seems
> to actually reduce the count after a while. Start it again, and the count
> increases. It's 100% reproducible for me.
>
> Relevant parts of varnishstat -1:
>
> MAIN.bans 507 . Count of bans
> MAIN.bans_completed 505 . Number of bans marked
> 'completed'
> MAIN.bans_obj 507 . Number of bans using
> obj.*
> MAIN.bans_req 0 . Number of bans using
> req.*
> MAIN.bans_added 25714 0.18 Bans added
> MAIN.bans_deleted 25207 0.18 Bans deleted
> MAIN.bans_tested 19528 0.14 Bans tested against
> objects (lookup)
> MAIN.bans_obj_killed 8168 0.06 Objects killed by bans
> (lookup)
> MAIN.bans_lurker_tested 20704629 147.19 Bans tested against
> objects (lurker)
> MAIN.bans_tests_tested 67431 0.48 Ban tests tested
> against objects (lookup)
> MAIN.bans_lurker_tests_tested 20721896 147.31 Ban tests tested
> against objects (lurker)
> MAIN.bans_lurker_obj_killed 13909 0.10 Objects killed by
> bans (lurker)
> MAIN.bans_dups 15323 0.11 Bans superseded
> by other bans
> MAIN.bans_lurker_contention 0 0.00 Lurker gave way
> for lookup
> MAIN.bans_persisted_bytes 1619932 . Bytes used by the
> persisted ban lists
> MAIN.bans_persisted_fragmentation 1613241 . Extra bytes
> in persisted ban lists due to
> fragmentation
>
> Relevant parts of my VCL:
>
> http://git.sesse.net/?p=remoteglot;a=blob;f=default.vcl;h=38631cb4f1d3c6f399dd4fb1378dec993339aa32;hb=HEAD
>
> This is Varnish from git, 7746e30e2c53cf55f0f2525bb3f49c9ee83e9611.

New description:

Hi,

I have a site where almost every backend response (vcl_backend_response)
produces a new ban, of the form:

ban ( "obj.http.x-analysis == 1 && obj.http.x-rglm != " +
beresp.http.x-rglm );

Pretty soon, these bans go into completed state. However, for some reason
the ban lurker doesn't manage to delete them, even though there are no
req.* bans. This seems to go on and on until I have hundreds of thousands
of bans, and BAN_Insert and ban_lurker both take significant amounts of
CPU time. Making the ban lurker wake up more often does not seem to help
anything; the ban count still goes up and never seems to go down (at all).

If I stop the backend entirely, so no requests ever go through, it seems
to actually reduce the count after a while. Start it again, and the count
increases. It's 100% reproducible for me.

Relevant parts of varnishstat -1:
{{{
MAIN.bans 507 . Count of bans
MAIN.bans_completed 505 . Number of bans marked
'completed'
MAIN.bans_obj 507 . Number of bans using
obj.*
MAIN.bans_req 0 . Number of bans using
req.*
MAIN.bans_added 25714 0.18 Bans added
MAIN.bans_deleted 25207 0.18 Bans deleted
MAIN.bans_tested 19528 0.14 Bans tested against
objects (lookup)
MAIN.bans_obj_killed 8168 0.06 Objects killed by bans
(lookup)
MAIN.bans_lurker_tested 20704629 147.19 Bans tested against
objects (lurker)
MAIN.bans_tests_tested 67431 0.48 Ban tests tested against
objects (lookup)
MAIN.bans_lurker_tests_tested 20721896 147.31 Ban tests tested
against objects (lurker)
MAIN.bans_lurker_obj_killed 13909 0.10 Objects killed by
bans (lurker)
MAIN.bans_dups 15323 0.11 Bans superseded by
other bans
MAIN.bans_lurker_contention 0 0.00 Lurker gave way
for lookup
MAIN.bans_persisted_bytes 1619932 . Bytes used by the
persisted ban lists
MAIN.bans_persisted_fragmentation 1613241 . Extra bytes in
persisted ban lists due to
fragmentation
}}}

Relevant parts of my VCL:

http://git.sesse.net/?p=remoteglot;a=blob;f=default.vcl;h=38631cb4f1d3c6f399dd4fb1378dec993339aa32;hb=HEAD

This is Varnish from git, 7746e30e2c53cf55f0f2525bb3f49c9ee83e9611.

--

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by lkarsten):

Discussed during bugwash today. Did you reduce ban_lurker_sleep?

We'll need to set up something to reproduce this to figure out what is
happening.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by Sesse):

Yes, I've tried reducing ban_lurker_sleep. From the original bug report:
“Making the ban lurker wake up more often does not seem to help anything;
the ban count still goes up and never seems to go down (at all).”

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by RyanS):

Our Varnish 4.0.3 installation probably suffers from the same problem.

We use Varnish 4.0.3 for out website and serve a lot of pages with semi-
unlimited (i.e. 1 year) TTL. When content gets changed, we ban te cache
object through special http headers. Please note that there can be
250.000+ new bans per day.

Our problem is that page load times turn out to be slower and slower the
longer Varnish runs. When checking with "varnishstat -1" it seems that
band never get deleted. MAIN.bans_deleted is always 0.

When i login to varnishadm and type the ban.list command I see a long list
of bans with status "C" for "Completed". Varnishstat -1 shows me that
there can be hundreds of thousands of them. They never get deleted.

---

Here are the important part from our VCL:

sub vcl_recv {

if (req.method == "BAN") {
if (!client.ip ~ purgers) {
return (synth(405, "Not allowed"));
}

if (req.http.X-Cache-Tags) {
ban("obj.http.X-Cache-Tags ~ " + req.http.X-Cache-Tags);
return (synth(200, "Banned"));
}

if (req.http.X-Url) {
ban("obj.http.x-origurl ~ " + req.http.X-Url);
return (synth(200, "Banned"));
}

return (synth(405, "No cache tags provided"));
}

...
}

sub vcl_backend_response {
set beresp.http.x-origurl = bereq.url;
...
}

---

Here's an example of the ban.list output from varnishadm:

1428440119.975700 20 C
1428440119.875178 21 C
1428440119.775048 0 C
1428440119.675068 1 C
1428440119.575059 0 C
1428440119.474236 0 C
1428440119.374664 1 C
1428440119.275055 0 C
1428440119.173203 1 C
1428440119.070568 1 C
1428440118.968622 0 C
1428440118.867101 0 C
1428440118.767099 2 C
1428440118.665274 3 C
1428440118.565995 2 C
1428440118.463959 4 C
1428440118.360379 3 C
1428440118.259975 4 C
1428440118.157665 4 C
1428440118.054391 8 C
1428440117.953973 3 C
1428440117.851816 16 C
1428440117.749820 7 C
1428440117.647959 8 C
1428440117.546431 2 C
1428440117.446593 2 C
1428440117.345096 1 C
1428440117.245096 0 C
1428440117.143993 0 C
1428440117.!

---

Here's output from varnishstat -1 a couple of hours after restart:

MAIN.bans 148860 . Count of bans
MAIN.bans_completed 148137 . Number of bans marked
'completed'
MAIN.bans_obj 148859 . Number of bans using
obj.*
MAIN.bans_req 0 . Number of bans using
req.*
MAIN.bans_added 148860 3.93 Bans added
MAIN.bans_deleted 0 0.00 Bans deleted
MAIN.bans_tested 2792056 73.77 Bans tested against
objects (lookup)
MAIN.bans_obj_killed 168 0.00 Objects killed by bans
(lookup)
MAIN.bans_lurker_tested 32706072512 864097.03 Bans tested against
objects (lurker)
MAIN.bans_tests_tested 347445702 9179.54 Ban tests tested against
objects (lookup)
MAIN.bans_lurker_tests_tested 32706072533 864097.03 Ban tests tested
against objects (lurker)
MAIN.bans_lurker_obj_killed 132363 3.50 Objects killed by
bans (lurker)
MAIN.bans_dups 58 0.00 Bans superseded by
other bans
MAIN.bans_lurker_contention 1303 0.03 Lurker gave way
for lookup
MAIN.bans_persisted_bytes 24958452 . Bytes used by the
persisted ban lists
MAIN.bans_persisted_fragmentation 22912281 . Extra bytes in
persisted ban lists due to fragmentation

As you can see, MAIN.bans_deleted is 0.

--

I've already increased ban_lurker_batch to 100.000 and decreased
ban_lurker_sleep to 0.001 sec, with no effect.

If you need more information, please let me know.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by karlvr):

Registering my interest in this ticket. I have exactly the same scenario
on my Varnish 4.0.3 instance.

bans_deleted sits at 1. Always.
bans and bans_completed are 505395 and 450786 respectively (currently).

The Varnish server becomes slower and slower to serve requests, so I
restart it at least once per day. I'm happy to run tests, and to try out
patches.

Should bans_deleted be going up? It seems like it should be?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:5>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by karlvr):

Attempting to debug this:

in `cache_ban.c`: `ban_cleantail` is being called, as expected. However
the ban at the `ban_head` has a `refcount` > 0, which I guess means that
there are objects in the cache that still refer to it?

So am I correct in assuming that bans can only be deleted once there are
no older objects in the cache? In which case perhaps the behaviour I'm
observing, and others are observing above, is expected?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:6>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by daniel.s):

Hi,

I'm having some issues with bans that might be related to this ticket.

I'm running Varnish 4.0.3 with a configuration where we end up with lots
of bans or with bans that affect lots of objects. After a day of use we
have more than 400k bans in the list, most of them are completed but they
are still in the list.

The issue I'm seeing is that varnish eventually becomes really slow with
an increased time to first byte from varnishncsa logs, the number of
threads spikes until it hits the max and then we start dropping
connections. After a while, the situation recovers. But this keeps
happening until we restart varnish.

I haven't been able to find a strong correlation yet, but it seems to be
related to having a huge amount of bans_lurker_tests_tested (which I'm not
sure what it does)

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:7>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by lucascherifi):

Hi !

I have exactly the same in V 4.0.3. May someone has an idea ?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:8>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by lucascherifi):

karlvr, you were right. I tried to set the cache control response header
of the back end responses to 20sec and the MAIN.bans number decrease to
one after 20sec.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:9>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by phk):

"so am I correct in assuming that bans can only be deleted once there are
no older objects in the cache? In which case perhaps the behaviour I'm
observing, and others are observing above, is expected? "

Its slightly more complicated.

We can only delete a ban after all *older* cached objects have been tested
against it.

If the ban contains any "req.*" tests, that can only happen when somebody
gets a cache-hit on that object.

If the ban is composed entirely of "obj.*" tests, the ban-lurker should be
able to "wash" it against all the cached objects (slowly, over time) and
the ban will be marked 'completed', the capital 'C' you see in the output.

However, because of the way we lock the ban-list, we cannot actually
remove the completed ban from the list if it is somewhere in the middle,
we can only delete the last ban on the list.

So if the last ban is using req.* and stuck until either the objects that
hasn't been checked yet expire or get a cache-hit, you can see a lot of
these 'Completed' bans accumulate in the list.

This is not optimal, but we havn't found a performance-cheap way of
solving this issue.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:10>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by Sesse):

I don't think this fully explains the behavior here; like I said in the
very first message, I don't have any req.* bans at all.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:11>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+--------------------
Reporter: Sesse | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: lurker |
----------------------+--------------------

Comment (by phk):

... which Is why I have left this ticket open until we find the bug :-)

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:12>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+----------------------------------------
Reporter: Sesse | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: lurker |
----------------------+----------------------------------------
Changes (by Poul-Henning Kamp <phk@…>):

* status: new => closed
* owner: => Poul-Henning Kamp <phk@…>
* resolution: => fixed


Comment:

In [91d77ac75fba9e8240966ce3e52771118e92b3a0]:
{{{
#!CommitTicketReference repository=""
revision="91d77ac75fba9e8240966ce3e52771118e92b3a0"
Modify the ban_lurker so we lift oc's as far up the ban-list as we
can when we check a batch of lurkable bans.

For obj.* only bans, this should concentrate the entire list at the
very top.

If there are req.* bans, the oc's end up on the bans right below
the req.* bans.

Fixes #1635

(As much as we can fix it)
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:13>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1635: Completed bans keep accumulating [ In reply to ]
#1635: Completed bans keep accumulating
----------------------+----------------------------------------
Reporter: Sesse | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: lurker |
----------------------+----------------------------------------

Comment (by Lasse Karstensen <lkarsten@…>):

In [2e7b89e0ea1273f881019200cf4e1748ba3a093a]:
{{{
#!CommitTicketReference repository=""
revision="2e7b89e0ea1273f881019200cf4e1748ba3a093a"
Modify the ban_lurker so we lift oc's as far up the ban-list as we
can when we check a batch of lurkable bans.

For obj.* only bans, this should concentrate the entire list at the
very top.

If there are req.* bans, the oc's end up on the bans right below
the req.* bans.

Fixes #1635

(As much as we can fix it)
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1635#comment:14>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs