Mailing List Archive: #1632: Debian: postinst broken

#1632: Debian: postinst broken

varnish-bugs at varnish-cache

Nov 20, 2014, 2:47 AM

Post #1 of 10 (2131 views)

#1632: Debian: postinst broken
---------------------+-----------------------
Reporter: idl0r | Type: defect
Status: new | Priority: normal
Milestone: | Component: packaging
Version: unknown | Severity: normal
Keywords: |
---------------------+-----------------------
Hi,

the postinst script of the official Debian files does a "start" instead of
"restart" which thus results into "[FAIL] Starting HTTP accelerator:
varnishd failed!" if the daemons are already started/running. This will
lead into a package "not fully installed or removed".

# /etc/init.d/varnish start
[FAIL] Starting HTTP accelerator: varnishd failed!

A restart should be used instead, for all services, varnish, varnishncsa
and varnishlog.
Or, as "wedge" just mentioned in #varnish:
wedge | postint should stop varnish prior to upgrade / config changes
wedge | usually this is what most packages do

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Nov 21, 2014, 7:43 AM

Post #2 of 10 (2120 views)

#1632: Debian: postinst broken
-----------------------+----------------------
Reporter: idl0r | Owner:
Type: defect | Status: closed
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution: invalid
Keywords: |
-----------------------+----------------------
Changes (by lkarsten):

* status: new => closed
* resolution: => invalid

Comment:

Please file this with the Debian bugtracker.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Nov 21, 2014, 7:48 AM

Post #3 of 10 (2108 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner:
Type: defect | Status: reopened
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------
Changes (by idl0r):

* status: closed => reopened
* resolution: invalid =>

Comment:

Nope, sorry, this is from repo.varnish-cache.org.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Dec 1, 2014, 1:59 AM

Post #4 of 10 (2102 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------
Changes (by lkarsten):

* owner: => lkarsten
* status: reopened => new

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Dec 10, 2014, 6:07 AM

Post #5 of 10 (2096 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------

Comment (by lkarsten):

I'd love some input from ssm or tfheen on this.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Dec 16, 2014, 4:48 AM

Post #6 of 10 (2087 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------

Comment (by ssm):

The package installation will run "stop" in "prerm" of the old package,
and "start" in the "postinst" of the new one.

These are added by the "#DEBHELPER#" markers at package build times by
"debhelper" in the debian/*.postinst and debian/*.prerm files.

As long as we do this, the packages will follow Debian policy.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:5>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

May 4, 2015, 4:30 AM

Post #7 of 10 (1977 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------

Comment (by lkarsten):

Discussed during bugwash today.

[13:27:02] < Mithrandir> it's also not a bug, the preinst stops varnish,
then postinst starts it again
[13:27:06] < Mithrandir> this is how all init scripts work

+Review this as part of preparation to 4.1.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:6>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Sep 7, 2015, 1:04 PM

Post #8 of 10 (1816 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------

Comment (by lkarsten):

Having worked on the init scripts for 4.1 today, I don't have any specific
input.

I'll try to get some upgrade testing done later in the week, but as far as
I've seen so far it works as it is.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:7>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Nov 2, 2015, 4:49 AM

Post #9 of 10 (1723 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution:
Keywords: |
-----------------------+-----------------------

Comment (by idl0r):

The Upgrade to 4.1 worked fine so far. I guess this issue can be closed.
Thanks!

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:8>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1632: Debian: postinst broken [ In reply to ]

varnish-bugs at varnish-cache

Nov 2, 2015, 6:17 AM

Post #10 of 10 (1730 views)

#1632: Debian: postinst broken
-----------------------+-----------------------
Reporter: idl0r | Owner: lkarsten
Type: defect | Status: closed
Priority: normal | Milestone:
Component: packaging | Version: unknown
Severity: normal | Resolution: fixed
Keywords: |
-----------------------+-----------------------
Changes (by lkarsten):

* status: new => closed
* resolution: => fixed

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1632#comment:9>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs