Mailing List Archive

#1603: vcl_hit: rename return(fetch) to return(miss) or have return(fetch) go to
backend / v_b_f
----------------------+--------------------
Reporter: slink | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------

Comment (by fgsch):

Do we want to do anything about this?

I think changing vcl_hit{} to go to vcl_backend_fetch{} makes sense but I
appreciate this could break anyone depending on vcl_hit{} going to
vcl_miss{} on `return(fetch)`.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1603#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

#1603: vcl_hit: rename return(fetch) to return(miss) or have return(fetch) go to
backend / v_b_f
----------------------+----------------------------------------
Reporter: slink | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------
Changes (by Poul-Henning Kamp <phk@…>):

* status: new => closed
* owner: => Poul-Henning Kamp <phk@…>
* resolution: => fixed


Comment:

In [a27af9f8f286f1d7a38b91928426685a1f33493f]:
{{{
#!CommitTicketReference repository=""
revision="a27af9f8f286f1d7a38b91928426685a1f33493f"
Fix an oversight: The correct and systematic thing is for vcl_hit{}
to return(miss) rather than return(fetch).

For now return(fetch) is still allowed, we don't want to bump vcl
version for something this trivial, but it emits a SLT_VCL_Error
urging people to change their VCL.

Fixes #1603
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1603#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

#1603: vcl_hit: rename return(fetch) to return(miss) or have return(fetch) go to
backend / v_b_f
----------------------+----------------------------------------
Reporter: slink | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------

Comment (by Nils Goroll <nils.goroll@…>):

In [d454fc1a2675844fa2c5b015a5b4cf0bfdbc9730]:
{{{
#!CommitTicketReference repository=""
revision="d454fc1a2675844fa2c5b015a5b4cf0bfdbc9730"
Typo

Fixes #1603
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1603#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

#1603: vcl_hit: rename return(fetch) to return(miss) or have return(fetch) go to
backend / v_b_f
----------------------+----------------------------------------
Reporter: slink | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------

Comment (by Nils Goroll <nils.goroll@…>):

In [bf5e38e60b8dbba055ccdea6a3d90b977302e1fd]:
{{{
#!CommitTicketReference repository=""
revision="bf5e38e60b8dbba055ccdea6a3d90b977302e1fd"
Update docs: vcl_hit{} return(miss)

Fixes #1603
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1603#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs