Mailing List Archive

#1598: Varnish asserts if the backend returns header lines without ':' and doing backend IMS
#1598: Varnish asserts if the backend returns header lines without ':' and doing
backend IMS
----------------------+-------------------
Reporter: martin | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Keywords:
----------------------+-------------------
See attached test case.

The test case fails both current master and the 4.0 branch. Asserts on not
finding the char ':' in the string in HTTP_Merge().

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1598>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1598: Varnish asserts if the backend returns header lines without ':' and doing backend IMS [ In reply to ]
#1598: Varnish asserts if the backend returns header lines without ':' and doing
backend IMS
----------------------+--------------------
Reporter: martin | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------

Comment (by martin):

Should we skip these headers during response parsing? Logged with
SLT_BogoHeader?

Or fail the backend response completely?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1598#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1598: Varnish asserts if the backend returns header lines without ':' and doing backend IMS [ In reply to ]
#1598: Varnish asserts if the backend returns header lines without ':' and doing
backend IMS
----------------------+----------------------------------------
Reporter: martin | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------
Changes (by Poul-Henning Kamp <phk@…>):

* owner: => Poul-Henning Kamp <phk@…>
* status: new => closed
* resolution: => fixed


Comment:

In [3eae7f22a8e842f47c169cfb1f4fd335b0af65da]:
{{{
#!CommitTicketReference repository=""
revision="3eae7f22a8e842f47c169cfb1f4fd335b0af65da"
Issue 400 code if header lines lack a ':'

Fixes #1598
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1598#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1598: Varnish asserts if the backend returns header lines without ':' and doing backend IMS [ In reply to ]
#1598: Varnish asserts if the backend returns header lines without ':' and doing
backend IMS
----------------------+----------------------------------------
Reporter: martin | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------

Comment (by Lasse Karstensen <lkarsten@…>):

In [ef6f15e5521829d60cb44233b8d5fe5ad29f3620]:
{{{
#!CommitTicketReference repository=""
revision="ef6f15e5521829d60cb44233b8d5fe5ad29f3620"
Allow invalid headers in 304 backend responses.

Allow the backend server to send headers lacking ":"/colon in
them when responding to a conditional request yielding a 304 response.

In master/4.1 such responses are aborted as invalid. The backend is
clearly not feeling well.

Since we've accepted it nicely for 200 responses so far in Varnish 4.0,
continue that trend also for 304s.

Fixes: #1598
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1598#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs