Mailing List Archive

Here's a fix for the following little issue:
Empty log messages mess up the changeset view, at least in FireFox and
Internet Explorer:
the Message: and Files: dt elements are overlapped.

Instead of fixing the stylesheet (I wouldn't know how to do it anyway :)),
I think it was better to make it explicit that there was no log message...

-- CB


Index: Changeset.py

===================================================================

--- Changeset.py (revision 943)

+++ Changeset.py (working copy)

@@ -177,14 +177,18 @@


change_info = self.get_change_info (self.rev)
changeset_info = self.get_changeset_info (self.rev)
+ changeset_message = changeset_info['message']
+ if changeset_message:
+ message =
wiki_to_html(util.wiki_escape_newline(changeset_message),
+ self.req.hdf, self.env, self.db)
+ else:
+ message = "<p><i>(No message set for revision %d)</i></p>"
% self.rev

self.req.hdf.setValue('changeset.time',
time.asctime
(time.localtime(int(changeset_info['time']))))
author = changeset_info['author'] or 'None'
self.req.hdf.setValue('changeset.author', util.escape(author))
- self.req.hdf.setValue('changeset.message',
-
wiki_to_html(util.wiki_escape_newline(changeset_info['message']),
- self.req.hdf, self.env,
self.db))
+ self.req.hdf.setValue('changeset.message', message)
self.req.hdf.setValue('changeset.revision', str(self.rev))
util.add_dictlist_to_hdf(change_info, self.req.hdf,
'changeset.changes')
self.req.hdf.setValue('changeset.href',