Mailing List Archive

[PATCH] style/markup refactoring of general header/footer
Howdy,

as I've proposed before on this list, I'm working on a cleanup of the
CSS and markup used by Trac in the default templates. I've decided to
split up this work into smaller, manageable chunks and submit those as
individual patches. Here's the first one.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: trac_css1.patch
Type: application/octet-stream
Size: 16819 bytes
Desc: not available
Url : /archive/trac/attachments/20040514/7e97d3a0/trac_css1.a
-------------- next part --------------


This patch only affects the styles and markup of the header and footer
used on every Trac page. A "side effect" of this patch is that it
reverts change [510] to fix #372. If you don't agree with my
argumentation in the description of that ticket, this patch probably
isn't for you :-)

I've tested these changes across a wide array of browsers on Win2K and
OSX. The rendering of the header and footer is extremely consistent
between all of those browsers, with the unfortunate exception of Opera
(see #372). Besides the improved clarity of the markup and the style
sheet (IMHO, of course), the header now also behaves a lot better when
the text is resized, and the layout works correctly in IE5/Mac.

I think this patch would be safe to integrate for 0.7 final, thus I'm
proposing it as a fix for ticket #372.

Cheers,
Chris
--
Christopher Lenz
/=/ cmlenz at gmx.de
RE: [PATCH] style/markup refactoring of general header/footer [ In reply to ]
Hi Chris,

I see that this is a diff-style file - how is it to be applied
(apologies for being ignorant)

Cheers,

:D

--------------------------------------------------------------------
Daragh Fitzpatrick Daragh@UChicago.edu (773) 702-8976

Solutions Architect NSIT Administrative Systems
Renewal Projects and Architecture University of Chicago
--------------------------------------------------------------------
-----Original Message-----
From: trac-bounces@bobcat.edgewall.com
[mailto:trac-bounces@bobcat.edgewall.com] On Behalf Of Christopher Lenz
Sent: Friday, May 14, 2004 9:28 AM
To: trac@bobcat.edgewall.com
Subject: [Trac] [PATCH] style/markup refactoring of general header/footer

Howdy,

as I've proposed before on this list, I'm working on a cleanup of the CSS
and markup used by Trac in the default templates. I've decided to split up
this work into smaller, manageable chunks and submit those as individual
patches. Here's the first one.
[PATCH] style/markup refactoring of general header/footer [ In reply to ]
On Friday 14 May 2004 10:27 am, Christopher Lenz wrote:
> Howdy,
>
> as I've proposed before on this list, I'm working on a cleanup of the
> CSS and markup used by Trac ...
*snip*
> I think this patch would be safe to integrate for 0.7 final, thus I'm
> proposing it as a fix for ticket #372.

Nice work, Chris :)

You're right that the patch should be part of 0.7 as well, it cleans the CSS
up quite nicely.

Thanks for the patch :)

--
Daniel Lundin | Edgewall Software
daniel@edgewall.com | Professional Linux & Open Source Consulting
| http://www.edgewall.com/
Re: [PATCH] style/markup refactoring of general header/footer [ In reply to ]
Hi Daragh,

on Unixes you'd simply use 'patch', on Windows you can use tools like
TortoiseSVN (if you're working on checkout from the repository) or, I
believe, WinMerge (@SourceForge.Net). Or of course you get Unix on
Windows by just installing Cygwin ;-)

Cheers,
Chris

Am 14.05.2004 um 16:40 schrieb Daragh Fitzpatrick:
> Hi Chris,
>
> I see that this is a diff-style file - how is it to be applied
> (apologies for being ignorant)
>
> Cheers,
>
> :D
>
> --------------------------------------------------------------------
> Daragh Fitzpatrick Daragh@UChicago.edu (773) 702-8976
>
> Solutions Architect NSIT Administrative Systems
> Renewal Projects and Architecture University of Chicago
> --------------------------------------------------------------------
--
Christopher Lenz
/=/ cmlenz at gmx.de