Mailing List Archive

[The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: jonas
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: general | Version: devel
Severity: normal | Keywords:
--------------------------------+-------------------------------------------
It is difficult or impossible to find this information otherwise.

--
Ticket URL: <http://trac.edgewall.org/ticket/3520>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets@lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: cboos
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: journaling |
--------------------------------+-------------------------------------------
Changes (by cboos):

* keywords: => journaling
* owner: jonas => cboos

Comment:

See also TracDev/Proposals/Journaling, which discusses the matter of
making the change listener interfaces more effective.

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:1>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets@lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: cboos
Type: enhancement | Status: new
Priority: normal | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: journaling |
--------------------------------+-------------------------------------------
Changes (by cmlenz):

* milestone: => 0.10

Comment:

Would be a good idea to get this change into 0.10 to avoid the API
breakage in a subsequent release.

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:2>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets@lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: cboos
Type: enhancement | Status: new
Priority: normal | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: journaling |
--------------------------------+-------------------------------------------
Comment (by cboos):

You mean that for 0.10, we should simply add the author info, like:
{{{
#!diff
- def ticket_changed(ticket, comment, old_values):
+ def ticket_changed(ticket, author, comment, old_values):
}}}
Yes, why not.

But, I think that in the long run, the API should evolve anyway, along the
lines of the proposal mentioned above.

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:3>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets@lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: journaling |
--------------------------------+-------------------------------------------
Changes (by cboos):

* owner: cboos =>

Comment:

I'll do something about this in 0.11, if in the meantime (for 0.10 or
0.10.x)
someone wants to implement this, feel free.

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:4>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets@lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: mgood
Type: enhancement | Status: assigned
Priority: normal | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: journaling |
--------------------------------+-------------------------------------------
Changes (by mgood):

* owner: => mgood
* status: new => assigned

Comment:

Replying to [comment:3 cboos]:
> You mean that for 0.10, we should simply add the author info, like:
{{{
#!diff
- def ticket_changed(ticket, comment, old_values):
+ def ticket_changed(ticket, author, comment, old_values):
}}}
> Yes, why not.

For consistency with the `IWikiChangeListener` maybe `author` should go
after `comment`:

{{{
#!python
def ticket_changed(ticket, comment, author, old_value):
}}}

I can do this to make sure it gets in for [milestone:0.10].

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:5>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets@googlegroups.com
To unsubscribe from this group, send email to trac-tickets-unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: mgood
Type: enhancement | Status: closed
Priority: normal | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution: fixed
Keywords: journaling |
--------------------------------+-------------------------------------------
Changes (by mgood):

* status: assigned => closed
* resolution: => fixed

Comment:

Ok. Added in r3692.

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:6>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets@googlegroups.com
To unsubscribe from this group, send email to trac-tickets-unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---
Re: [The Trac Project] #3520: ITicketChangeListener.ticket_changed should be passed the author of the change [ In reply to ]
#3520: ITicketChangeListener.ticket_changed should be passed the author of the
change
--------------------------------+-------------------------------------------
Reporter: exarkun@divmod.com | Owner: mgood
Type: enhancement | Status: closed
Priority: normal | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution: fixed
Keywords: journaling |
--------------------------------+-------------------------------------------
Comment (by kkkkoaa01102006aaaa):

Keep a good job up!

--
Ticket URL: <http://trac.edgewall.org/ticket/3520#comment:>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets@googlegroups.com
To unsubscribe from this group, send email to trac-tickets-unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---