Mailing List Archive

Re: vesamenu.c32 new command [patch]
Op 16-05-2007 om 09:34 schreef Erik Lehmann:
>
> Hi,
>
> i think i always send a patch last october:
>
> "The default start position of the menu box for is the first row of
> the screen. I'm using the background image option and want
> to have the menu on the middle of the screen.
> With the attached patch it's possible to use the new config
> switch "MENU STARTROW" to define the top row for the
> menu box."

[-- Attachment #2: start-row.patch --]

>
> I don't know why it's not included yet.

It is indeed a pitty the posting from october the 4th didn't get
any feedback. Words as "We all have our (busy) live" don't apply
because freedom software is about sharing resources, to have time
for things that can't be shared.


As I understand it, are these things that help getting a patch included:

1) A posting that confirms the working of the patch.

2) Beside the program source code, also an update on the documentation.

3) Generate the patch by the revision tool this project uses.


Let me elaborate those items.

1: This is the tough one. It needs a person who also wants/needs/desires
the functionality. Because that includes the motivation to master the
skills to apply the patch and rebuilding from source. Learning applying
a patch and rebuild a program is one of my best investments I ever made.

2: The good thing about misspelled manual update, is that it easier get
fixed that non existing documentation.

3: Syslinux uses "git"



Hope this helps
Geert Stappers

_______________________________________________
SYSLINUX mailing list
Submissions to SYSLINUX@zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.
Re: vesamenu.c32 new command [patch] [ In reply to ]
Geert Stappers wrote:
>
> 3: Syslinux uses "git"
>

This is actually a biggie. The less work I have to apply a patch the
more likely it is I'm not going to put it off and possibly forget about it.

git contains special tools to take a patch in email and apply it
directly to the repository with comments and all, but it requires a
fairly carefully formatted email. The format of that email is part of
the Linux kernel documentation:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=a417b25fb1aa40f62234c222db0a4be1cfaa938d;hb=HEAD

If you send me an email in this format, I can apply it using the git
tools in literally a few seconds.

-hpa

_______________________________________________
SYSLINUX mailing list
Submissions to SYSLINUX@zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.
Re: providing patches [ In reply to ]
Op 17-05-2007 om 13:31 schreef H. Peter Anvin:
> Geert Stappers wrote:
> >
> > 3: Syslinux uses "git"
> >
>
> This is actually a biggie. The less work I have to apply a patch the
> more likely it is I'm not going to put it off and possibly forget about it.
>
> git contains special tools to take a patch in email and apply it
> directly to the repository with comments and all, but it requires a
> fairly carefully formatted email. The format of that email is part of
> the Linux kernel documentation:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=a417b25fb1aa40f62234c222db0a4be1cfaa938d;hb=HEAD
>
> If you send me an email in this format, I can apply it using the git
> tools in literally a few seconds.
>
> -hpa


/me reposting an important message

_______________________________________________
SYSLINUX mailing list
Submissions to SYSLINUX@zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.