Mailing List Archive

Riccardo Alfieri skrev den 2022-12-28 11:44:
> Hello everyone,
>
> just FYI, I published the updated rules to have DQS working on SA
> 4.0.0+ (https://github.com/spamhaus/spamassassin-dqs)
>
> Thanks to the effort of all SA developers there is no need anymore to
> install a dedicated plugin, as all of our functions have been
> backported in SA's core code, so now it's only a bunch of .cf to copy.
>
> Please consider the rules as a BETA. They have been tested by a few
> customers without issues, but YMMV.

rule testers test nothing it seems :=)


Dec 28 14:12:09.349 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
171): replace_rules\t__KAM_VIAGRA2
Dec 28 14:12:09.363 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
581): replace_rules \t__KAM_UNIV11 __KAM_UNIV15 __KAM_UNIV3B
Dec 28 14:12:09.622 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
6846): replace_rules\t__KAM_VM3
Dec 28 14:12:09.624 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
6879): replace_rules\t__KAM_BENEFICIARY2
Dec 28 14:12:09.632 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
7038): freemail_domains my.com mediacombb.net tutanota.com mega.nz
ntlworld.com
Dec 28 14:12:09.641 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
7287): replace_rules\t__KAM_SPO2_2 __KAM_SPO2_3
Dec 28 14:12:09.649 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
7473): replace_rules \t__KAM_FAKE_NORTON1 __KAM_FAKE_NORTON2
__KAM_FAKE_NORTON3 __KAM_FAKE_NORTON4
Dec 28 14:12:09.653 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
7512): replace_rules\t__KAM_FAKE_CAN_POST2
Dec 28 14:12:09.683 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
8178): mimeheader \t__KAM_DATING3\tContent-type =~
/\\.(png|jpe?g)\\"?$/i
Dec 28 14:12:09.688 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
8308): replace_rules\t__KAM_FAKE_COSTCO2 __KAM_FAKE_COSTCO3
Dec 28 14:12:09.698 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
8502): replace_tag
ABUSE_DOMAINS\t\t(?:\\.(sa\\.com|za\\.com|co\\.in))(\\b|\\/|$|\\@)
Dec 28 14:12:09.698 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
8504): replace_rules\t__KAM_SA_ZA_ABUSE1 __KAM_SA_ZA_ABUSE2
Dec 28 14:12:09.701 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
8592): mimeheader \t__KAM_OCTET_PHISH1 \tContent-Type =~
/application\\/octet-stream.*\\.s?html?\\.?\\"?$/i
Dec 28 14:12:09.706 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/kam_sa-channels_mcgrail_com/KAM.cf (line
8717): replace_rules\tKAM_OBFU_GEEK
Dec 28 14:12:09.769 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/spamassassin_snb_it/20_ITA.cf (line 26):
mimeheader\t__ITA_ATTACH_ANY\t\tContent-Type =~
m,\\bapplication/(.*)\\b,i
Dec 28 14:12:09.769 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/spamassassin_snb_it/20_ITA.cf (line 29):
urirhssub __SEM_FRESH10 fresh10.spameatingmonkey.net. A 2
Dec 28 14:12:09.792 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/spamassassin_snb_it/20_ITA.cf (line 590):
mimeheader\t__XLS_BAD_ATTACH\tContent-Disposition =~
/(comunica|fattura|inps|istruzioni|documento[0-9]).*(?:_|\\-)([0-9]+)\\.xls/i
Dec 28 14:12:09.801 [1461] warn: config: failed to parse line in
/var/lib/spamassassin/4.000000/spamassassin_snb_it/20_ITA.cf (line 818):
mimeheader __XLS_ATTACH Content-Disposition =~ /\\.xls/i
Dec 28 14:12:09.837 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 71):
urirhssub\tSH_BODYURI_REVERSE_SBL\tyour_DQS_key.zen.dq.spamhaus.net.\tA
127.0.0.2
Dec 28 14:12:09.837 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 77):
urirhssub\tSH_BODYURI_REVERSE_CSS\tyour_DQS_key.zen.dq.spamhaus.net.\tA
127.0.0.3
Dec 28 14:12:09.837 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 83):
urirhssub\tSH_BODYURI_REVERSE_DROP\tyour_DQS_key.zen.dq.spamhaus.net.\tA
127.0.0.9
Dec 28 14:12:09.838 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 89):
urirhssub\tSH_BODYURI_REVERSE_XBL\tyour_DQS_key.zen.dq.spamhaus.net.\tA
127.0.0.4
Dec 28 14:12:09.839 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 149): urirhssub
URIBL_DBL_BLOCKED_OPENDNS your_DQS_key.dbl.dq.spamhaus.net. A
127.255.255.254
Dec 28 14:12:09.839 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 150): urirhssub
URIBL_DBL_BLOCKED your_DQS_key.dbl.dq.spamhaus.net. A
127.255.255.255
Dec 28 14:12:09.839 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 152): uridnssub
URIBL_ZEN_BLOCKED_OPENDNS your_DQS_key.zen.dq.spamhaus.net. A
127.255.255.254
Dec 28 14:12:09.839 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 153): uridnssub URIBL_ZEN_BLOCKED
your_DQS_key.zen.dq.spamhaus.net. A 127.255.255.255
Dec 28 14:12:09.839 [1461] warn: config: failed to parse line in
/etc/mail/spamassassin/sh.cf (line 159):
urirhssub\tSH_DBL_ABUSED_FULLHOST\tyour_DQS_key.dbl.dq.spamhaus.net.\tA
127.0.1.102-106
Dec 28 14:12:10.073 [1461] warn: rules: unknown eval 'check_hashbl_tag'
for SH_REVERSE_ZRD_FRESH
Dec 28 14:12:10.073 [1461] warn: rules: unknown eval
'check_hashbl_emails' for SH_ZRD_HEADERS_VERY_FRESH
Dec 28 14:12:10.073 [1461] warn: rules: unknown eval 'check_hashbl_tag'
for SH_HELO_DBL
Dec 28 14:12:10.073 [1461] warn: rules: unknown eval
'check_hashbl_emails' for SH_ZRD_HEADERS_FRESH
Dec 28 14:12:10.073 [1461] warn: rules: unknown eval
'check_hashbl_emails' for SH_DBL_BODY
Dec 28 14:12:10.073 [1461] warn: rules: unknown eval
'check_hashbl_emails' for SH_DBL_HEADERS
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval
'check_hashbl_emails' for SH_ZRD_BODY_VERY_FRESH
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval
'check_hashbl_emails' for SH_ZRD_BODY_FRESH
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_hashbl_tag'
for SH_HELO_ZRD_VERY_FRESH
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_hashbl_tag'
for SH_REVERSE_ZRD_VERY_FRESH
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_hashbl_tag'
for SH_HELO_ZRD_FRESH
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_hashbl_tag'
for SH_REVERSE_DBL
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_uridnsbl'
for SH_BODYURI_REVERSE_SBL
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_uridnsbl'
for SH_BODYURI_REVERSE_CSS
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_uridnsbl'
for SH_DBL_ABUSED_FULLHOST
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_uridnsbl'
for SH_BODYURI_REVERSE_XBL
Dec 28 14:12:10.074 [1461] warn: rules: unknown eval 'check_uridnsbl'
for SH_BODYURI_REVERSE_DROP


above is with only check plugin enabled, this should lint without
warnings

Do you have hashbl plugin enabled?

On 12/28/2022 8:17 AM, Benny Pedersen wrote:
>
> above is with only check plugin enabled, this should lint without
> warnings

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

Kevin A. McGrail skrev den 2022-12-28 14:20:
> Do you have hashbl plugin enabled?

read your quoted line again ?

>
> On 12/28/2022 8:17 AM, Benny Pedersen wrote:
>>
>> above is with only check plugin enabled, this should lint without
>> warnings

I have no idea what the check plugin is.  Read your quoted line again.

On 12/28/2022 8:22 AM, Benny Pedersen wrote:
> Kevin A. McGrail skrev den 2022-12-28 14:20:
>> Do you have hashbl plugin enabled?
>
> read your quoted line again ?
>
>>
>> On 12/28/2022 8:17 AM, Benny Pedersen wrote:
>>>
>>> above is with only check plugin enabled, this should lint without
>>> warnings

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

Kevin A. McGrail skrev den 2022-12-28 14:24:
> I have no idea what the check plugin is.  Read your quoted line again.

don't read the source ?,
https://github.com/apache/spamassassin/blob/trunk/rules/v320.pre#L21

i have in my test only this plugin enabled, rest is disabled

rule maintainers must do there homework

Looks like you didn't replace the DQS key in the template, as it's
outlined in the README.

You also have a lot of parsing errors that are not normal (\t should be
a <tab>, don't know why your system renders that badly)

On 28/12/22 14:17, Benny Pedersen wrote:
> Dec 28 14:12:09.837 [1461] warn: config: failed to parse line in
> /etc/mail/spamassassin/sh.cf (line 71):
> urirhssub\tSH_BODYURI_REVERSE_SBL\tyour_DQS_key.zen.dq.spamhaus.net.\tA
> 127.0.0.2
>
--
Best regards,
Riccardo Alfieri

Spamhaus Technology
https://www.spamhaus.com/

On 28/12/22 14:20, Kevin A. McGrail wrote:

> Do you have hashbl plugin enabled?
>
>
Ah, I thought it was enabled by default in SA 4.0.

--
Best regards,
Riccardo Alfieri

Spamhaus Technology
https://www.spamhaus.com/

Riccardo Alfieri skrev den 2022-12-28 14:34:
> Looks like you didn't replace the DQS key in the template, as it's
> outlined in the README.

i will not share my key here

> You also have a lot of parsing errors that are not normal (\t should
> be a <tab>, don't know why your system renders that badly)

sh.cf miss ifplugin lines multi places

not my fault

> On 28/12/22 14:17, Benny Pedersen wrote:
>
>> Dec 28 14:12:09.837 [1461] warn: config: failed to parse line in
>> /etc/mail/spamassassin/sh.cf (line 71):
>>
> urirhssub\tSH_BODYURI_REVERSE_SBL\tyour_DQS_key.zen.dq.spamhaus.net.\tA
>> 127.0.0.2
>
> --
> Best regards,
> Riccardo Alfieri
>
> Spamhaus Technology
> https://www.spamhaus.com/

On Wed, Dec 28, 2022 at 01:35:22PM +0000, Riccardo Alfieri wrote:
> On 28/12/22 14:20, Kevin A. McGrail wrote:
>
> > Do you have hashbl plugin enabled?
> >
> >
> Ah, I thought it was enabled by default in SA 4.0.

It is enabled by default for new installs in v342.pre (old users must enable
it manually). But like with any other loadable plugin, one MUST check use
"ifplugin" to check that it's loaded.

On 12/28/2022 8:35 AM, Riccardo Alfieri wrote:
>> Do you have hashbl plugin enabled?
> Ah, I thought it was enabled by default in SA 4.0.
You are correct.  HashBL is by default enabled in a stock distribution
with v342.pre.  That doesn't mean the trouble reporter has it enabled.

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

Riccardo Alfieri skrev den 2022-12-28 14:35:
> On 28/12/22 14:20, Kevin A. McGrail wrote:
>
>> Do you have hashbl plugin enabled?

> Ah, I thought it was enabled by default in SA 4.0.

only check is on --lint testing, if all plugins is default enabled
multiple errors is hidded

hopefully developpers know why

ifplugin is missing in sh.cf

On 12/28/2022 8:33 AM, Benny Pedersen wrote:
>> I have no idea what the check plugin is.  Read your quoted line again.
>
> don't read the source ?,
> https://github.com/apache/spamassassin/blob/trunk/rules/v320.pre#L21

My question was: Do you have the Plugin HashBL enabled.

> i have in my test only this plugin enabled, rest is disabled
I would guess not having a stock plugin that the ruleset uses would
explain your error.
> rule maintainers must do there homework

And posters should do their homework as well and post information that
shows what is the problem, how to recreate it, and the expected
outcome.  Your posts on this thread are borderline nonsensical.

Only after multiple back and forths can someone divine what you might be
mentioning.

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

Kevin A. McGrail skrev den 2022-12-28 14:44:
> On 12/28/2022 8:35 AM, Riccardo Alfieri wrote:
>>> Do you have hashbl plugin enabled?
>> Ah, I thought it was enabled by default in SA 4.0.
> You are correct.  HashBL is by default enabled in a stock distribution
> with v342.pre.  That doesn't mean the trouble reporter has it enabled.

bingo ::))

hint for rule maintainers is to disables all plugins, execpt check
plugin, now spamassassin -D warn --lint should not give any warn lines

Kevin A. McGrail skrev den 2022-12-28 14:48:

> And posters should do their homework as well and post information that
> shows what is the problem, how to recreate it, and the expected
> outcome. Your posts on this thread are borderline nonsensical.

i did, but you did not understand me, sorry for that

> Only after multiple back and forths can someone divine what you might
> be mentioning.

no its possible not understanded yet :/

On 28/12/22 14:44, Henrik K wrote:

> It is enabled by default for new installs in v342.pre (old users must enable
> it manually). But like with any other loadable plugin, one MUST check use
> "ifplugin" to check that it's loaded.
Ok, thanks for the clarification.

Would you then suggest to add also a:

ifplugin Mail::SpamAssassin::Plugin::URIDNSBL

to the .cf files where check_rbl , urirhssub etc are used?

--
Best regards,
Riccardo Alfieri

Spamhaus Technology
https://www.spamhaus.com/

Going further, you might just encapsulate your entire cf file in to
ifplugin checks, one for URIDNSBL and one for HashBL and any other
plugins you need.

However, both URIDNSBL and HashBL are enabled by default from checking
the source code.

Regards,

KAM

On 12/28/2022 8:58 AM, Riccardo Alfieri wrote:
>
> Would you then suggest to add also a:
>
> ifplugin Mail::SpamAssassin::Plugin::URIDNSBL
>
> to the .cf files where check_rbl , urirhssub etc are used?

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

On Wed, Dec 28, 2022 at 01:58:55PM +0000, Riccardo Alfieri wrote:
> On 28/12/22 14:44, Henrik K wrote:
>
> > It is enabled by default for new installs in v342.pre (old users must enable
> > it manually). But like with any other loadable plugin, one MUST check use
> > "ifplugin" to check that it's loaded.
> Ok, thanks for the clarification.
>
> Would you then suggest to add also a:
>
> ifplugin Mail::SpamAssassin::Plugin::URIDNSBL
>
> to the .cf files where check_rbl , urirhssub etc are used?

It would be standard to use it yes.

Of course it's a bit of a double-edged sword, since with ifplugin the rules
might silently be ignored. Especially for Gentoo users. ;-)

On Wed, Dec 28, 2022 at 09:04:09AM -0500, Kevin A. McGrail wrote:
>
> However, both URIDNSBL and HashBL are enabled by default from checking the
> source code.

Just keep in mind that HashBL is only enabled for fresh 4.0.0 installs, it
wasn't default previously.

Kevin A. McGrail skrev den 2022-12-28 15:04:
> Going further, you might just encapsulate your entire cf file in to
> ifplugin checks, one for URIDNSBL and one for HashBL and any other
> plugins you need.

bingo

> However, both URIDNSBL and HashBL are enabled by default from checking
> the source code.

irrelevant for rule maintainers that some plugins is enabled by default,
all rules must be tested with plugins disabled and still no warn in
--lint

On Wed, Dec 28, 2022 at 04:06:01PM +0200, Henrik K wrote:
> On Wed, Dec 28, 2022 at 01:58:55PM +0000, Riccardo Alfieri wrote:
> > On 28/12/22 14:44, Henrik K wrote:
> >
> > > It is enabled by default for new installs in v342.pre (old users must enable
> > > it manually). But like with any other loadable plugin, one MUST check use
> > > "ifplugin" to check that it's loaded.
> > Ok, thanks for the clarification.
> >
> > Would you then suggest to add also a:
> >
> > ifplugin Mail::SpamAssassin::Plugin::URIDNSBL
> >
> > to the .cf files where check_rbl , urirhssub etc are used?
>
> It would be standard to use it yes.
>
> Of course it's a bit of a double-edged sword, since with ifplugin the rules
> might silently be ignored. Especially for Gentoo users. ;-)

Maybe would be even good idea to use something like this:

ifplugin Mail::SpamAssassin::Plugin::HashBL
....
else
error: Please activate HashBL plugin in v342.pre
endif

Which would result in:

$ spamassassin --lint
Dec 28 16:12:54.518 [764158] warn: config: failed to parse line in /var/foo/sh.cf (line 4): error: Please activate HashBL plugin in v342.pre
Dec 28 16:12:55.415 [764158] warn: lint: 1 issues detected, please rerun with debug enabled for more information

Of course this wouldn't be good for sa-updated rules. Would need some way
to generate a warning without failing lint.

Henrik K skrev den 2022-12-28 15:06:

> Of course it's a bit of a double-edged sword, since with ifplugin the
> rules
> might silently be ignored. Especially for Gentoo users. ;-)

gentoo users does not use precompiled problems

Wow, as it's enabled in v342.pre, that would imply it was enabled in
3.4.2.  We should not have changed a past pre file for the 4.0.0 release
IMO but added it to the 4.0.0.pre file.  Such is life.  Should we fix it
for 4.0.1?

On 12/28/2022 9:07 AM, Henrik K wrote:
> Just keep in mind that HashBL is only enabled for fresh 4.0.0 installs, it
> wasn't default previously.

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

This was discussed and approved in some of the 4.0.0 bugs. There should be
no need to revisit it. It still wouldn't make sense to have loadplugin
HashBL in two *.pre files.

On Wed, Dec 28, 2022 at 09:18:51AM -0500, Kevin A. McGrail wrote:
> Wow, as it's enabled in v342.pre, that would imply it was enabled in 3.4.2.?
> We should not have changed a past pre file for the 4.0.0 release IMO but
> added it to the 4.0.0.pre file.? Such is life.? Should we fix it for 4.0.1?
>
> On 12/28/2022 9:07 AM, Henrik K wrote:
> > Just keep in mind that HashBL is only enabled for fresh 4.0.0 installs, it
> > wasn't default previously.
>
> --
> Kevin A. McGrail
> KMcGrail@Apache.org
>
> Member, Apache Software Foundation
> Chair Emeritus Apache SpamAssassin Project
> https://www.linkedin.com/in/kmcgrail - 703.798.0171

As I say, such is life.  It's a minor thing.  Any objections to a
comment if it doesn't exist that documents it was enabled by default in
4.0.0 in the 3.4.2 pre file?

On 12/28/2022 9:21 AM, Henrik K wrote:
> This was discussed and approved in some of the 4.0.0 bugs. There should be
> no need to revisit it. It still wouldn't make sense to have loadplugin
> HashBL in two *.pre files.
>
> On Wed, Dec 28, 2022 at 09:18:51AM -0500, Kevin A. McGrail wrote:
>> Wow, as it's enabled in v342.pre, that would imply it was enabled in 3.4.2.
>> We should not have changed a past pre file for the 4.0.0 release IMO but
>> added it to the 4.0.0.pre file.  Such is life.  Should we fix it for 4.0.1?
>>
>> On 12/28/2022 9:07 AM, Henrik K wrote:
>>> Just keep in mind that HashBL is only enabled for fresh 4.0.0 installs, it
>>> wasn't default previously.
>> --
>> Kevin A. McGrail
>> KMcGrail@Apache.org
>>
>> Member, Apache Software Foundation
>> Chair Emeritus Apache SpamAssassin Project
>> https://www.linkedin.com/in/kmcgrail - 703.798.0171

--
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171