Mailing List Archive

http://bugzilla.spamassassin.org/show_bug.cgi?id=3521





------- Additional Comments From jm@jmason.org 2004-06-18 15:15 -------
again, I'd suggest a skip on windows. We *could* use Algorithm::Diff, but since
that test is never likely to have a platform-specific problem, and hasn't failed
in years, I think it'd be overkill...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3521





------- Additional Comments From quinlan@pathname.com 2004-06-18 21:32 -------
It looks like we're just using diff to compare whether two files are the
same. This can be done in perl, the tests should just be fixed.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3521





------- Additional Comments From sidney@sidney.com 2004-06-18 23:46 -------
Created an attachment (id=2052)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2052&action=view)
patch to use File::Compare::compare_text instead of a system call to command
line diff

Is it true that File::Compare is always available in Perl? The attached patch
uses File::Compare::compare_text instead of the diff subroutine that was
defined to shell out to the command line diff. compare_text is necessary
instead of compare because the original file has unix newlines while the
generated test file has native OS newlines and compare would fail under
Windows.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.