Mailing List Archive

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From jeffc@surbl.org 2004-06-15 23:06 -------
Yes, please remove references to be.surbl.org as it is now deprecated in favor
of ws.surbl.org, where [be]'s domains now appear. Should I create a separate
ticket requesting the removal of [be] references in the urirhsbl
http://www.spamassassin.org/full/3.0.x/dist/rules/25_uribl.cf sample conf?

ph.surbl.org support is a good thing, with the caveat that the ph domains appear
only in multi.surbl.org. In other words, ph.surbl.org does not exist as a
standalone list. With only about 200 entries we felt it was too small to get
its own list. Perhaps we should revisit this question as it gets larger.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From jeffc@surbl.org 2004-06-15 23:36 -------
Bug 3420 is similar. Not sure how to suggest addressing that fact; I'm sure you
guys do.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From spamassassin-contrib@msquadrat.de 2004-06-16 11:11 -------
+0.75: code-wise it looks good, I haven't tried it though. But that option's
name "urirhsblsub" is a joke, isn't it? ;) What does it stand for "URI Right
Hand Side BlackList Subroutine"?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511

jm@jmason.org changed:

What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |3420
nThis| |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From jm@jmason.org 2004-06-16 17:02 -------
well, I could change it to "urirhsbl-subtest" or similar... is it worth the bother?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From spamassassin-contrib@msquadrat.de 2004-06-16 17:29 -------
It would make it at least a bit clearer. The current urirhsblsub looks like
something Duncan types on his keyboard when he's looking for a name for a new
project ;-)

Btw, I had another look at the URIDNSBL.pm code and noticed that a key
'urirhsblsub' is nowehere referenced in the code itself. Neither does your
patch introduce anything. Is it not needed?

Also is your patch missing the POD description for the new config key.

As I now don't understand that patch at all, I have to revert my vote to -0.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511

jm@jmason.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #2036 is|0 |1
obsolete| |



------- Additional Comments From jm@jmason.org 2004-06-16 18:17 -------
Created an attachment (id=2043)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2043&action=view)
impl r2

OK, no wonder -- I forgot a file from the svn diff! ;) that's the danger of
R-T-C with multiple patches in your tree.... this one should be better. note
that I've renamed it to "urirhsbl-subtest" now.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511

jm@jmason.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #2043 is|0 |1
obsolete| |



------- Additional Comments From jm@jmason.org 2004-06-16 18:22 -------
Created an attachment (id=2044)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2044&action=view)
impl r3

yeesh. ignore that last one -- again ;)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

> well, I could change it to "urirhsbl-subtest" or similar... is it
> worth the bother?

No '-' in the name, please!

I think the original name was fine, but for please don't make it longer
and don't add characters outside of the range [a-z].

--
Daniel Quinlan
http://www.pathname.com/~quinlan/

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From quinlan@pathname.com 2004-06-16 23:40 -------
Subject: Re: [review] patch to add support for multi.surbl.org

> well, I could change it to "urirhsbl-subtest" or similar... is it
> worth the bother?

No '-' in the name, please!

I think the original name was fine, but for please don't make it longer
and don't add characters outside of the range [a-z].





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From jm@jmason.org 2004-06-17 09:50 -------
Subject: Re: [review] patch to add support for multi.surbl.org

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Daniel Quinlan writes:
>> well, I could change it to "urirhsbl-subtest" or similar... is it
>> worth the bother?
>
>No '-' in the name, please!
>
>I think the original name was fine, but for please don't make it longer
>and don't add characters outside of the range [a-z].

ok. can we vote based on the assumption that I'm changing it
back to "urirhsblsub" on checkin? I don't want to have to respin
a patch for every possible name until we decide on one.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFA0cvNQTcbUG5Y7woRAj/EAKCA+RuXJiBjCF09ppZ4FMfgrzE5KwCeLNa6
x6QHk9k99RySSsb1TUPh2is=
=1irY
-----END PGP SIGNATURE-----





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From quinlan@pathname.com 2004-06-17 09:53 -------
Subject: Re: [review] patch to add support for multi.surbl.org

Justin Mason <jm@jmason.org> writes:

> ok. can we vote based on the assumption that I'm changing it
> back to "urirhsblsub" on checkin? I don't want to have to respin
> a patch for every possible name until we decide on one.

Unless someone comes up with a better name... maybe just "urirhssub"
would be fine.

+1 on original name
+1 on my suggestion
-1 on adding non-word characters ;-)

Daniel





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511





------- Additional Comments From spamassassin-contrib@msquadrat.de 2004-06-17 10:20 -------
+1 on any name if I'm the only one who has issues with it ;~)

I did some eye-trace through the code and even understood it, makes sense to
me. Apart from that I can't test it though as I don't know what this feature
is exactly about :)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3511

jm@jmason.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED



------- Additional Comments From jm@jmason.org 2004-06-17 22:50 -------
ok, applied!



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.