Mailing List Archive

[Bug 3096] RFE: improve mass-check so that it can be run from a different directory, and implement module structure to support 'masses' tools
http://bugzilla.spamassassin.org/show_bug.cgi?id=3096

jm@jmason.org changed:

What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |2853
nThis| |



------- Additional Comments From jm@jmason.org 2004-03-17 09:15 -------
related to bug 2853



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 3096] RFE: improve mass-check so that it can be run from a different directory, and implement module structure to support 'masses' tools [ In reply to ]
http://bugzilla.spamassassin.org/show_bug.cgi?id=3096





------- Additional Comments From duncf@debian.org 2004-03-22 22:11 -------
Created an attachment (id=1867)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=1867&action=view)
Proposed patch

Okay this patch allows mass-check to be run anywhere. If the --dist option is
given, (or it auto-detects, based on ../spamassassin.raw) it assumes it's in
its usual home, masses/. Otherwise, it should pick up the default paths for
stuff (local rules, user_prefs, etc) and it should use
~/.spamassassin/mass-check as userstate, unless overriden.

Instead of output to the traditional spam.log and ham.log, it outputs to a
single file, masses.log. (jm suggested this in bug 2853 comment 2)

The first character of the line is now s, h, N or P depending on whether the
message was correctly marked as spam, correctly marked as ham, a false negative
or false positive. The intent was that this is human readable, and useful for
quick statistics.

On IRC quinlan suggested that this might not be ideal, and perhaps two fields
would be better, or that one field could be s-c, s-m for spam-caught,
spam-missed, etc.

I chose the field the way I did based on the fact that the old scripts
generally expect a one character field, so it required less changes. Since I
intend to re-write the rest of the masses/ stuff, changing it shouldn't be a
problem. Also, I find a two field system confusing to read, I always forget
which is which ;-)

Also, this code is probably not tested as well as it should be. I'm not running
HEAD, so it's tough for me to test (not making excuses, just saying...).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.