Mailing List Archive

Author: jm
Date: Fri Dec 8 06:59:47 2006
New Revision: 484624

URL: http://svn.apache.org/viewvc?view=rev&rev=484624
Log:
ruleqa.cgi: fix bug where XML output was inhibiting any rule output whatsoever, which was causing rule-update production to stop

Modified:
spamassassin/trunk/masses/rule-qa/automc/ruleqa.cgi

Modified: spamassassin/trunk/masses/rule-qa/automc/ruleqa.cgi
URL: http://svn.apache.org/viewvc/spamassassin/trunk/masses/rule-qa/automc/ruleqa.cgi?view=diff&rev=484624&r1=484623&r2=484624
==============================================================================
--- spamassassin/trunk/masses/rule-qa/automc/ruleqa.cgi (original)
+++ spamassassin/trunk/masses/rule-qa/automc/ruleqa.cgi Fri Dec 8 06:59:47 2006
@@ -151,9 +151,8 @@
$self->{s}{scoremap} = 1;
}

- if (!grep { $_ } values %{$self->{s}}) {
- $self->{s}{new} = 1;
- }
+ # always show "new" set, though
+ $self->{s}{new} = 1;
}

sub get_url_switch {
@@ -436,6 +435,16 @@

};
}
+
+ # debug: log the chosen sets parameters etc.
+ print "<!-- ",
+ "{s}{new} = $self->{s}{new}\n",
+ "{s}{age} = $self->{s}{age}\n",
+ "{s}{all} = $self->{s}{all}\n",
+ "{s}{overlap} = $self->{s}{overlap}\n",
+ "{s}{scoremap} = $self->{s}{scoremap}\n",
+ "{s}{xml} = $self->{s}{xml}\n",
+ "-->\n";

$self->show_all_sets_for_daterev($self->{daterev}, $self->{daterev});