Mailing List Archive

Author: felicity
Date: Sat Sep 9 22:51:32 2006
New Revision: 441913

URL: http://svn.apache.org/viewvc?view=rev&rev=441913
Log:
bug 4418: remove HTML_LINK_IMAGE_BUG and HTML_WEB_BUGS rules due to bad performance

Modified:
spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm
spamassassin/trunk/rules/20_html_tests.cf

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm?view=diff&rev=441913&r1=441912&r2=441913
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm Sat Sep 9 22:51:32 2006
@@ -650,9 +650,6 @@
if ($tag eq "img" && exists $self->{inside}{a} && $self->{inside}{a} > 0) {
$self->{uri}->{$self->{anchor_last}}->{anchor_text}->[-1] .= "<img>\n";
$self->{anchor}->[-1] .= "<img>\n";
- if ($self->{anchor_last} =~ /\.(?:pl|cgi|php|asp|jsp|cfm)\b/i) {
- $self->put_results(anchor_image_bug => 1);
- }
}

if ($tag eq "img" && exists $attr->{width} && exists $attr->{height}) {
@@ -675,12 +672,6 @@
if ($width > 0 && $height > 0) {
$area = $width * $height;
$self->{image_area} += $area;
- }
- # this is intended to match any width and height if they're specified
- if (exists $attr->{src} &&
- $attr->{src} =~ /\.(?:pl|cgi|php|asp|jsp|cfm)\b/i)
- {
- $self->put_results(web_bugs => 1);
}
}
if ($tag eq "form" && exists $attr->{action}) {

Modified: spamassassin/trunk/rules/20_html_tests.cf
URL: http://svn.apache.org/viewvc/spamassassin/trunk/rules/20_html_tests.cf?view=diff&rev=441913&r1=441912&r2=441913
==============================================================================
--- spamassassin/trunk/rules/20_html_tests.cf (original)
+++ spamassassin/trunk/rules/20_html_tests.cf Sat Sep 9 22:51:32 2006
@@ -222,9 +222,6 @@
describe HTML_IMAGE_RATIO_06 HTML has a low ratio of text to image area
describe HTML_IMAGE_RATIO_08 HTML has a low ratio of text to image area

-body HTML_LINK_IMAGE_BUG eval:html_test('anchor_image_bug')
-describe HTML_LINK_IMAGE_BUG HTML link plus image plus web bug
-
body HTML_LINK_PUSH_HERE eval:html_text_match('anchor', '(?i)(?:push|go|cl[1l]ck)\s*(?:here|this)')
describe HTML_LINK_PUSH_HERE HTML link text says "push here" or similar

@@ -266,9 +263,6 @@
describe HTML_ATTR_BAD HTML has many bad attributes in tags
body HTML_ATTR_UNIQUE eval:html_range('attr_unique_bad','0.5','1.0')
describe HTML_ATTR_UNIQUE HTML appears to have random attributes in tags
-
-body HTML_WEB_BUGS eval:html_test('web_bugs')
-describe HTML_WEB_BUGS Image tag intended to identify you

body HTML_TAG_BALANCE_BODY eval:html_tag_balance('body', '!= 0')
describe HTML_TAG_BALANCE_BODY HTML has unbalanced "body" tags