Mailing List Archive: rsyslog 4.1.4

rsyslog 4.1.4 - one (small) bug left

Jan 30, 2009, 5:34 AM

Post #1 of 3 (795 views)

Hi all,

I have now basically ported the race bugfix to all branches
(verification and double-check still in the works). While doing this, I
noticed that one small issues slipped my attention with yesterday's
4.1.4 version. If compiled with atomics, I unlock an already unlocked
mutex (which is destroyed with the very next statement) in msgDestruct.
That should not have any really bad effects (but you never know...). The
master branch is now updated, so you may want to pull a fixed version
from there. I will not do a new release just for this reason - it'll be
included in the next version.

Please note that git as of now already contains all the race fix for all
branches, but mostly untested. Just in case if you'd like to get them
quickly.

I will keep you posted.

Rainer
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com

Re: rsyslog 4.1.4 - one (small) bug left [ In reply to ]

rgerhards at hq

Jan 30, 2009, 8:28 AM

Post #2 of 3 (753 views)

Permalink

> -----Original Message-----
> From: rsyslog-bounces@lists.adiscon.com [mailto:rsyslog-
> bounces@lists.adiscon.com] On Behalf Of david@lang.hm
> Sent: Friday, January 30, 2009 6:29 PM
> To: rsyslog-users
> Subject: Re: [rsyslog] rsyslog 4.1.4 - one (small) bug left
>
> On Fri, 30 Jan 2009, Rainer Gerhards wrote:
>
> > Hi all,
> >
> > I have now basically ported the race bugfix to all branches
> > (verification and double-check still in the works). While doing
this,
> I
> > noticed that one small issues slipped my attention with yesterday's
> > 4.1.4 version. If compiled with atomics, I unlock an already
unlocked
> > mutex (which is destroyed with the very next statement) in
> msgDestruct.
> > That should not have any really bad effects (but you never know...).
> The
> > master branch is now updated, so you may want to pull a fixed
version
> > from there. I will not do a new release just for this reason - it'll
> be
> > included in the next version.
>
> so 4.1.4 should be using the atomics for queue management not mutexes?

It depends... If atomics are available, they are the preferred method.
If not available, the code falls back to mutexes.

Rainer
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com

Re: rsyslog 4.1.4 - one (small) bug left [ In reply to ]

david at lang

Jan 30, 2009, 9:28 AM

Post #3 of 3 (749 views)

Permalink

On Fri, 30 Jan 2009, Rainer Gerhards wrote:

> Hi all,
>
> I have now basically ported the race bugfix to all branches
> (verification and double-check still in the works). While doing this, I
> noticed that one small issues slipped my attention with yesterday's
> 4.1.4 version. If compiled with atomics, I unlock an already unlocked
> mutex (which is destroyed with the very next statement) in msgDestruct.
> That should not have any really bad effects (but you never know...). The
> master branch is now updated, so you may want to pull a fixed version
> from there. I will not do a new release just for this reason - it'll be
> included in the next version.

so 4.1.4 should be using the atomics for queue management not mutexes?

David Lang

> Please note that git as of now already contains all the race fix for all
> branches, but mostly untested. Just in case if you'd like to get them
> quickly.
>
> I will keep you posted.
>
> Rainer
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com
>
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com