Mailing List Archive: PATCH: objdir builds

PATCH: objdir builds

Mar 15, 2004, 8:57 PM

Post #1 of 3 (454 views)

The attached patch lets me successfully build Quagga in an object
directory "beside" the Quagga sources. That is, I build like this:

cd quagga-obj
../quagga/configure
gmake

All that was necessary was to change the "version.h" includes to
<lib/version.h>. The source file vtysh/vtysh_users.c already included
version.h that way.

Feedback appreciated.

Dave

--
David Young OJC Technologies
dyoung@ojctech.com Urbana, IL * (217) 278-3933

Re: PATCH: objdir builds {COMMITTED} [ In reply to ]

gdt at ir

Mar 16, 2004, 7:43 AM

Post #2 of 3 (440 views)

Permalink

I committed your patch (but please see HACKING and send a ChangeLog).
I guessed a bit, so please check my wording in the ChangeLog to see if
I got the reason right.

I built without objdirs and that worked ok. I would appreciate your
trying current cvs with objdirs.

--
Greg Troxel <gdt@ir.bbn.com>

Re: PATCH: objdir builds {COMMITTED} [ In reply to ]

gdt at ir

Mar 16, 2004, 6:32 PM

Post #3 of 3 (443 views)

Permalink

I get the impression that the whole source setup is a little dicey for
objdir builds; there is use of "" style includes a lot, rather than
<>. So I'm happy to adjust things (if it doesn't break regular
builds), but it would be nice if someone who really groks this were to
explain whether it is right, and if not what ought to change, from the
objdir big-picture point of view.

That said, such cleanliness cleanups are probably low on the priority
list, especially compared to making things actually work.

--
Greg Troxel <gdt@ir.bbn.com>

Mailing List Archive

Mailing List Archive

Attached Files: