Hi Sangeeta,
I hope you dont mind me Cc'ing quagga-dev - but i think it might be
useful to see if others have opinions. (there's a more general
behavioural issue here, see below).
On Tue, 14 Oct 2003, Sangeeta Misra wrote:
> Paul,
>
> I was trying things with quagga-0.96.3, and noticed that "write file"
> really does not save any of the debug commands that a user might type at
> the ENABLE mode of ospfd telnet UI (ie telnet <machinename> 2604). It
> only works in CONFIGURE mode. This looks broken to me
>
> One way to reproduce this bug is to try out the following steps:
> A. telnet localhost 2604
> B enable
> C sho run ( make sure the command you are about to type in D does not exist)
> D debug ospf event
> E write file
> C sho run ( you will note that the command at Step E really did not get
> saved in ospfd.conf file
> NOTE: You can also do a diff between the .sav file and the updated file
> to see the bug
>
> I have a fix for it - see attched. I would appreciate it if you can
> code review, and provide input as to if this is something that can
> be patched into the Quagga CVS repository
Hmm.... just looking at this now.
While your patch is fine and would solve the immediate problem at
hand, I think there's a bigger problem. Namely, for some reason
Zebra^WQuagga /deliberately/ distinguishes between config node debug
commands (the conf_debug_*) and enable node (term_debug_*).
What exactly the difference is supposed to be, i dont know. Maybe the
correct answer is that all term_debug_* should be cleared when the
user logs off the vty?
Or perhaps the term_debug_*'s should not go to the log file?
I dont know..
Ultimately, I think either have to:
- find some more useful behaviour for enable node debug. Unless the
current "enable node debug does not get saved behaviour" is what
people want.
otherwise:
- just remove the enable node/term_debug_* stuff altogether.
> Thanks in advance
> Sangeeta
regards,
--
Paul Jakma paul@clubi.ie paul@jakma.org Key ID: 64A2FF6A
warning: do not ever send email to spam@dishone.st
Fortune:
Computers don't actually think.
You just think they think.
(We think.)
I hope you dont mind me Cc'ing quagga-dev - but i think it might be
useful to see if others have opinions. (there's a more general
behavioural issue here, see below).
On Tue, 14 Oct 2003, Sangeeta Misra wrote:
> Paul,
>
> I was trying things with quagga-0.96.3, and noticed that "write file"
> really does not save any of the debug commands that a user might type at
> the ENABLE mode of ospfd telnet UI (ie telnet <machinename> 2604). It
> only works in CONFIGURE mode. This looks broken to me
>
> One way to reproduce this bug is to try out the following steps:
> A. telnet localhost 2604
> B enable
> C sho run ( make sure the command you are about to type in D does not exist)
> D debug ospf event
> E write file
> C sho run ( you will note that the command at Step E really did not get
> saved in ospfd.conf file
> NOTE: You can also do a diff between the .sav file and the updated file
> to see the bug
>
> I have a fix for it - see attched. I would appreciate it if you can
> code review, and provide input as to if this is something that can
> be patched into the Quagga CVS repository
Hmm.... just looking at this now.
While your patch is fine and would solve the immediate problem at
hand, I think there's a bigger problem. Namely, for some reason
Zebra^WQuagga /deliberately/ distinguishes between config node debug
commands (the conf_debug_*) and enable node (term_debug_*).
What exactly the difference is supposed to be, i dont know. Maybe the
correct answer is that all term_debug_* should be cleared when the
user logs off the vty?
Or perhaps the term_debug_*'s should not go to the log file?
I dont know..
Ultimately, I think either have to:
- find some more useful behaviour for enable node debug. Unless the
current "enable node debug does not get saved behaviour" is what
people want.
otherwise:
- just remove the enable node/term_debug_* stuff altogether.
> Thanks in advance
> Sangeeta
regards,
--
Paul Jakma paul@clubi.ie paul@jakma.org Key ID: 64A2FF6A
warning: do not ever send email to spam@dishone.st
Fortune:
Computers don't actually think.
You just think they think.
(We think.)