Mailing List Archive

[Bug 371] vtysh don't have end word at the end of write terminal
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=371





------- Additional Comments From nicolas@deffayet.com 2007-06-14 12:20 -------
Many tools like rancid don't work because they don't find word 'end' at the end
of the running configuration show by the command 'write terminal'

Fix:

--- quagga-0.99.7.org/vtysh/vtysh.c Sun Apr 29 14:40:42 2007
+++ quagga-0.99.7/vtysh/vtysh.c Thu Jun 14 12:12:41 2007
@@ -1720,6 +1720,8 @@
fp = NULL;
}

+ vty_out (vty, "end%s",VTY_NEWLINE);
+
return CMD_SUCCESS;
}

------- Additional Comments From paul@dishone.st 2007-06-14 13:20 -------
Hmm, lib/command.c prints out 'end' for 'write terminal', but not for 'write file'.

Do we know what the behaviour is supposed to be for the various cases? Also,
with regards to changing outputs: What is the least-harm option?






------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 371] vtysh don't have end word at the end of write terminal [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=371





------- Additional Comments From nicolas@deffayet.com 2007-06-14 15:33 -------
I confirm that write terminal don't add word 'end' at the end:

# write terminal
...
line vty
exec-timeout 60 0
!
#

If you try to use rancid on the device without word 'end' at the end, you will
get error from rancid: "End of run not found"



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 371] vtysh don't have end word at the end of write terminal [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=371


paul@dishone.st changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|maintainers@quagga.net |paul@dishone.st




------- Additional Comments From paul@dishone.st 2007-06-20 16:23 -------
Given write-terminal prints out end, and that no tool should be confused by
extra lines, i'll accept the bug.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 371] vtysh don't have end word at the end of write terminal [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=371


paul@dishone.st changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Resolution| |FIXED




------- Additional Comments From paul@dishone.st 2007-06-20 16:24 -------
Your fix was committed to CVS, thanks!



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs