Mailing List Archive

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=370


nicolas@deffayet.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|critical |major
Priority|Very High |High




------- Additional Comments From paul@dishone.st 2007-06-13 13:00 -------
Hi,

I dont think anything changed with regard to this feature.

Are you maybe /receiving/ a better default route from that neighbour? try:

sh ip bg neighbor ..... routes





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=370





------- Additional Comments From nicolas@deffayet.com 2007-06-13 23:41 -------
I don't receive better default route from that neighbor.

With the same bgpd.conf:
quagga-0.99.5-20061018: OK, default route announced
quagga-0.99.7-20070525: BAD, default route not announced

It's not a config problem.
default-originate don't work for IPv4 and IPv6 neighbor.

Can you please let me know more details about the change done in function
bgp_default_originate of bgp_route.c.diff ?
http://cvs.quagga.net/cgi-bin/viewcvs.cgi/quagga/bgpd/bgp_route.c.diff?r1=1.60&r2=1.61&diff_format=h
The origin of the bug is probably this ?



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=370


paul@dishone.st changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED






------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=370





------- Additional Comments From paul@dishone.st 2007-06-14 11:36 -------
Sorry, my testing was flawed. My test bgpd was passing on a learned default
rather than originating.

It is indeed broken, and it's down to the sanity check that was added to the top
of bgp_default_originate, which unfortunately has a very, very silly thinko. Fix is:

@@ -2370,7 +2370,7 @@ bgp_default_originate (struct peer *peer
struct peer *from;
int ret = RMAP_DENYMATCH;

- if (afi != AFI_IP || afi != AFI_IP6)
+ if (!(afi == AFI_IP || afi == AFI_IP6))
return;

bgp = peer->bgp;

Am testing it now.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=370


paul@dishone.st changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |FIXED




------- Additional Comments From paul@dishone.st 2007-06-14 12:19 -------
Fix tested as working and just committed to CVS. Closing.

Thanks!




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs