Mailing List Archive

Update of /cvsroot/python/python/dist/src/Lib/test
In directory usw-pr-cvs1:/tmp/cvs-serv7350

Modified Files:
test_userstring.py
Log Message:
I am mad. This test never worked!

The test function's signature should be

test(methodname, input, output, *args)

but the output argument was omitted. This caused all tests to fail,
because the expected output was passed as the initial argument to the
method call. But because of the way the test works (it compares the
results for a regular string to the results for a UserString instance
with the same value, and it's OK if both raise the same exception) the
test never failed!

I've fixed this, and also cleaned up a few warts in the verbose
output. Finally, I've made it possible to run the test stand-alone in
verbose mode by passing -v as a command line argument.

Now, the test will report failure related to zfill. That's not my
fault, that's a legitimate problem: the string_tests.py file contains
a test for the zfill() method (just added) but this method is not
implemented. The responsible party will surely fix this soon now.


Index: test_userstring.py
===================================================================
RCS file: /cvsroot/python/python/dist/src/Lib/test/test_userstring.py,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** test_userstring.py 9 Feb 2001 12:00:47 -0000 1.5
--- test_userstring.py 12 Apr 2002 16:25:39 -0000 1.6
***************
*** 9,21 ****

if __name__ == "__main__":
! verbose = 0

tested_methods = {}

! def test(methodname, input, *args):
global tested_methods
tested_methods[methodname] = 1
if verbose:
! print '%s.%s(%s) ' % (input, methodname, args),
u = UserString(input)
objects = [input, u, UserString(u)]
--- 9,21 ----

if __name__ == "__main__":
! verbose = '-v' in sys.argv

tested_methods = {}

! def test(methodname, input, output, *args):
global tested_methods
tested_methods[methodname] = 1
if verbose:
! print '%r.%s(%s)' % (input, methodname, ", ".join(map(repr, args))),
u = UserString(input)
objects = [input, u, UserString(u)]
***************
*** 25,45 ****
try:
f = getattr(object, methodname)
! res[i] = apply(f, args)
! except:
! res[i] = sys.exc_type
! if res[0] != res[1]:
! if verbose:
! print 'no'
! print `input`, f, `res[0]`, "<>", `res[1]`
! else:
if verbose:
print 'yes'
- if res[1] != res[2]:
- if verbose:
- print 'no'
- print `input`, f, `res[1]`, "<>", `res[2]`
else:
if verbose:
! print 'yes'

string_tests.run_method_tests(test)
--- 25,43 ----
try:
f = getattr(object, methodname)
! except AttributeError:
! f = None
! res[i] = AttributeError
! else:
! try:
! res[i] = apply(f, args)
! except:
! res[i] = sys.exc_type
! if res[0] == res[1] == res[2] == output:
if verbose:
print 'yes'
else:
if verbose:
! print 'no'
! print (methodname, input, output, args, res[0], res[1], res[2])

string_tests.run_method_tests(test)